Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime C maybe benchmark example #2195

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

paulcadman
Copy link
Collaborator

The constr_info_t struct has changed, so this example must be changed accordingly.

The benchmark builds are still broken because I missed this file in #2192

I've removed the unsupported wasm target from the compile.sh script in the benchmark directory to make it easier to spot errors.

@paulcadman paulcadman added this to the 0.4.1 milestone Jun 16, 2023
@paulcadman paulcadman requested a review from lukaszcz June 16, 2023 08:31
@paulcadman paulcadman self-assigned this Jun 16, 2023
@lukaszcz
Copy link
Collaborator

How do the benchmarks compile when doing the benchmarks? They don't use compile.sh? Now the WASM target name is wasm32-wasi.

@paulcadman
Copy link
Collaborator Author

How do the benchmarks compile when doing the benchmarks? They don't use compile.sh? Now the WASM target name is wasm32-wasi.

The benchmarks don't use compile.sh, the compiler invocations are defined in https://github.com/anoma/juvix/blob/main/bench/Variants.hs. However there is no way of compiling all the benchmark examples without running the benchmark suite, which takes several hours. The compile.sh script is useful for sanity checking the examples.

@paulcadman paulcadman merged commit 82a6f8c into main Jun 16, 2023
@paulcadman paulcadman deleted the fix-benchmark-runtime-c-2 branch June 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants