Fix benchmark runtime C examples #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
previously approved these changes
Jun 15, 2023
paulcadman
force-pushed
the
fix-benchmark-runtime-c
branch
from
e437bc7
to
6bf006d
Compare
lukaszcz
approved these changes
Jun 15, 2023
paulcadman
added a commit
that referenced
this pull request
Jun 16, 2023
The constr_info_t struct has changed, so this example must be changed accordingly. The benchmark builds are still broken because I missed this file in #2192 I've removed the unsupported wasm target from the `compile.sh` script in the benchmark directory to make it easier to spot errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constr_info_t struct has changed, so these examples must be changed accordingly.
This should fix the failing benchmark builds https://github.com/anoma/juvix-nightly-builds/actions/runs/5274325536/jobs/9538974076