Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support integers in the GEB backend #1778

Merged
merged 11 commits into from
Feb 3, 2023
Merged

Support integers in the GEB backend #1778

merged 11 commits into from
Feb 3, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz added this to the 0.3 - Valencia milestone Jan 27, 2023
@lukaszcz lukaszcz self-assigned this Jan 27, 2023
@lukaszcz lukaszcz changed the base branch from main to geb-integration January 27, 2023 14:55
@lukaszcz lukaszcz changed the base branch from geb-integration to main January 27, 2023 14:56
@lukaszcz lukaszcz force-pushed the geb-integers branch 3 times, most recently from 5c58491 to 4012ebf Compare February 1, 2023 12:24
@lukaszcz lukaszcz marked this pull request as ready for review February 1, 2023 12:27
@lukaszcz lukaszcz force-pushed the geb-integers branch 3 times, most recently from e8e34b2 to 87e638f Compare February 2, 2023 09:46
@lukaszcz lukaszcz mentioned this pull request Feb 3, 2023
Merged
jonaprieto
jonaprieto reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few new tests here: test005.x and test006.x.
Where are the actual test for these files, from the Haskell test suite?

@lukaszcz
Copy link
Collaborator Author

lukaszcz commented Feb 3, 2023

There are a few new tests here: test005.x and test006.x. Where are the actual test for these files, from the Haskell test suite?

There aren't any yet, because without the GEB evaluator there is no reliable way to automate the tests! We should add all GEB tests (and write some more) to the Haskell test suite once we have the evaluator.

@lukaszcz
Copy link
Collaborator Author

lukaszcz commented Feb 3, 2023

For now, I just checked manually that the GEB output is reasonable.

@jonaprieto jonaprieto merged commit 5e06441 into main Feb 3, 2023
@jonaprieto jonaprieto deleted the geb-integers branch February 3, 2023 11:46
jonaprieto pushed a commit that referenced this pull request Feb 3, 2023
@lukaszcz
Mid-square hashing implemented in JuvixCore (#1804)
14d1e5d 
- Can be compiled to GEB after merging #1778.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

Assignees

@lukaszcz lukaszcz

Labels
backend:geb
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.

Support integers in the GEB backend
2 participants
@lukaszcz @jonaprieto