New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Geb integration #1748

Merged

jonaprieto merged 20 commits into main from geb-integration

Feb 1, 2023

Collaborator

lukaszcz commented Jan 23, 2023 •

edited by jonaprieto

Loading

This PR:

Closes Add basic GEB backend #1647

It gives compilation errors for language features that require more substantial support (recursion, polymorphism). The additional features are to be implemented in future separate PRs.

Adds a new target geb to the CLI command juvix dev core compile, which produces a *.geb output file in the .juvix-build directory.
Adds a few tests. These are not yet checked automatically because there is no GEB evaluator; checking the *.geb output would be too brittle.

lukaszcz added the backend:geb label

lukaszcz added this to the 0.3 milestone

lukaszcz assigned lukaszcz and janmasrovira

lukaszcz force-pushed the geb-integration branch from 2721b98 to 58aec84 Compare

January 23, 2023 14:29

jonaprieto linked an issue

that may be closed by this pull request

Add basic GEB backend #1647

Closed

lukaszcz force-pushed the geb-integration branch from 98d5a80 to 41d1900 Compare

January 23, 2023 17:58

lukaszcz changed the title ~~Geb integration~~ Basic Geb integration

lukaszcz force-pushed the geb-integration branch from f257a4f to 09ea3ef Compare

January 25, 2023 15:43

lukaszcz unassigned janmasrovira

lukaszcz force-pushed the geb-integration branch 3 times, most recently from 9e10498 to 306692d Compare

January 27, 2023 12:25

lukaszcz marked this pull request as ready for review

January 27, 2023 12:52

lukaszcz requested review from jonaprieto and janmasrovira

January 27, 2023 14:01

lukaszcz force-pushed the geb-integration branch from 3b65387 to 58450aa Compare

January 27, 2023 14:27

lukaszcz mentioned this pull request

Support integers in the GEB backend #1778

Merged

lukaszcz force-pushed the geb-integration branch 3 times, most recently from ff71cf2 to f2bb6ae Compare

January 31, 2023 10:47

jonaprieto reviewed

View reviewed changes

app/Commands/Dev/Core/Compile.hs Outdated Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

app/Commands/Dev/Core/Compile.hs Outdated Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

app/Commands/Dev/Core/Compile.hs Outdated Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

src/Juvix/Compiler/Backend/Geb/Pretty/Base.hs Outdated Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

src/Juvix/Compiler/Backend/Geb/Pretty/Base.hs Outdated Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

src/Juvix/Compiler/Core/Language/Builtins.hs Show resolved Hide resolved

jonaprieto reviewed

View reviewed changes

src/Juvix/Compiler/Core/Transformation/ComputeTypeInfo.hs Show resolved Hide resolved

lukaszcz requested a review from jonaprieto

January 31, 2023 12:44

jonaprieto previously approved these changes

View reviewed changes

janmasrovira reviewed

View reviewed changes

Collaborator

janmasrovira left a comment

Some comments (I still have to review Translation/FromCore)

src/Juvix/Compiler/Backend/Geb/Extra.hs Outdated Show resolved Hide resolved

src/Juvix/Compiler/Backend/Geb/Language.hs Outdated Show resolved Hide resolved

src/Juvix/Compiler/Backend/Geb/Language.hs Show resolved Hide resolved

src/Juvix/Compiler/Backend/Geb/Language.hs Outdated Show resolved Hide resolved

src/Juvix/Compiler/Backend/Geb/Pretty/Options.hs Outdated Show resolved Hide resolved

lukaszcz dismissed jonaprieto’s stale review via

75bcb17

January 31, 2023 15:05

lukaszcz force-pushed the geb-integration branch from 75bcb17 to 8659b38 Compare

January 31, 2023 15:05

lukaszcz requested a review from janmasrovira

January 31, 2023 15:06

lukaszcz added 19 commits

February 1, 2023 10:30


          Geb data structures and S-expression output

61df63d


          make ormolu happy

a56f6d2


          Adjustments after conversation with Terence

01a1530


          stubs

059a383


          make ormolu happy

19c74a3


          transformations

7cd34da


          basic translation to GEB

1b2445e


          translate identifiers

e935705


          compute simple types in Core

ebf5b43


          CLI & bugfixes

1c857cd


          remove debug trace

9fd2f25


          make ormolu happy

059831c


          tests & bugfixes

8f38847


          make ormolu happy

bb45b25


          Adjust comment

7c5f2b2


          update cntlines.sh

a657695


          address review comments

8008d5a


          make ormolu happy

cc595b6


          address review comments

1a549f6

lukaszcz force-pushed the geb-integration branch from 8659b38 to 1a549f6 Compare

February 1, 2023 09:30


          fix ComputeTypeInfo

56bcde2

janmasrovira approved these changes

View reviewed changes

jonaprieto merged commit a5d19c5 into main

jonaprieto deleted the geb-integration branch

February 1, 2023 11:04

jonaprieto pushed a commit that referenced this pull request


          Support integers in the GEB backend (#1778)

5e06441

* Depends on PR #1748 
* Closes #1753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels