Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUS feature feedback #11

Merged
merged 5 commits into from
Jul 2, 2020
Merged

FUS feature feedback #11

merged 5 commits into from
Jul 2, 2020

Conversation

annakocheshkova
Copy link
Owner

Task name: AppCenterDistributeV3, AppCenterDistributeV2, AppCenterDistributeV1

Description: Apply feedback for microsoft#13204

@annakocheshkova annakocheshkova merged commit d965815 into feature/mc-fus Jul 2, 2020
}

export function mockFs() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like redundant row here

};

fs.createWriteStream = (s: string) => {
let stream = new Writable;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add types for any variables with non-constant value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants