Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add local as an option for FLASK_ENVIRONMENT_CONFIG variable in env.template file #665

Closed

Conversation

PrashanthPuneriya
Copy link
Contributor

@PrashanthPuneriya PrashanthPuneriya commented Jul 14, 2020

Description

Adds local value as an option for FLASK_ENVIRONMENT_CONFIG variable.

Fixes #663

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrashanthPuneriya please don't create PRs from develop branch of your fork , checkout to a suitable branch name and update this PR.

@PrashanthPuneriya
Copy link
Contributor Author

@vj-codes Thanks for informing me. What should I do of this pull request then?

@vj-codes
Copy link
Member

@PrashanthPuneriya just change the target branch of this PR, no need to send another one:)

@PrashanthPuneriya
Copy link
Contributor Author

@vj-codes Can you please elaborate? Just before your comment I have reset --hard this branch. Now I am confused. What should I do?

@vj-codes
Copy link
Member

vj-codes commented Jul 14, 2020

Ohhh now its better to send another PR
there's an edit option available comparing the main branch and your fork branch , where you could create a new one and update it in the same PR.

@PrashanthPuneriya
Copy link
Contributor Author

PrashanthPuneriya commented Jul 14, 2020

@vj-codes Ohh okay! My bad.
Just to clarify, now I need to create a new branch in my fork and make changes in that branch and then make a pull request from my branch to this develop-branch?

@vj-codes
Copy link
Member

yupp @PrashanthPuneriya

@PrashanthPuneriya
Copy link
Contributor Author

@vj-codes Can you please review #666 pull-request ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a missing environment config value to .env.template
2 participants