Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing environment config value to .env.template #663

Closed
PrashanthPuneriya opened this issue Jul 14, 2020 · 3 comments · Fixed by #666
Closed

Add a missing environment config value to .env.template #663

PrashanthPuneriya opened this issue Jul 14, 2020 · 3 comments · Fixed by #666
Assignees
@PrashanthPuneriya
Labels
Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers.

Comments

@PrashanthPuneriya
Copy link
Contributor

environment-variables.md doc specifies that the run configuration has 4 options: dev, local, test and prod values to be loaded. But, FLASK_ENVIRONMENT_CONFIG variable under .env.template file doesn't include local value as an option.
@PrashanthPuneriya
Copy link
Contributor Author

I would like to fix this issue if this is approved by mentors.

@vj-codes vj-codes added Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers. labels Jul 14, 2020
@vj-codes
Copy link
Member

Assigning you @PrashanthPuneriya
Happy coding!

This was referenced Jul 14, 2020
Closed
Closed
Merged
@isabelcosta
Copy link
Member

@PrashanthPuneriya this is a great issue 🎉 Next time could you please follow one of the templates suggested? You can use perhaps "User Story" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrashanthPuneriya PrashanthPuneriya

Labels
Category: Documentation/Training Improvements or additions to documentation. First Timers Only Good for newcomers.
Projects
None yet
Milestone
No milestone
3 participants
@isabelcosta @PrashanthPuneriya @vj-codes