Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: delete ISSUE_TEMPLATE.md #1032

Merged
merged 1 commit into from
Mar 14, 2021
Merged

doc: delete ISSUE_TEMPLATE.md #1032

merged 1 commit into from
Mar 14, 2021

Conversation

Sejalcodes
Copy link
Contributor

@Sejalcodes Sejalcodes commented Mar 5, 2021 •
edited
Loading

#1013 Deleted ISSUE_TEMPLATE.md file since it was an older version of ISSUE_TEMPLATE file

Fixes #1013

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1032 (c6e0348) into develop (479f1c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1032   +/-   ##
========================================
  Coverage    96.18%   96.18%           
========================================
  Files          100      100           
  Lines         5426     5426           
========================================
  Hits          5219     5219           
  Misses         207      207

@vj-codes vj-codes added the Status: Changes Requested Changes are required to be done by the PR author. label Mar 5, 2021
@vj-codes
Copy link
Member

vj-codes commented Mar 5, 2021

@Sejalcodes great work on creating your first PR to the repo , please update the link in contributing.md to the one mentioned in issue comments and then this PR can be reviewed/approved :)

vj-codes
vj-codes approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sejalcodes congrats on your first contribution !
LGTM 🎉

@vj-codes vj-codes added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Mar 5, 2021
@Sejalcodes
Copy link
Contributor Author

@Sejalcodes congrats on your first contribution !
LGTM 🎉

Thankyou so much, the community really helped!

ashwinijha6
ashwinijha6 reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@ashwinijha6 ashwinijha6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sejalcodes just a suggestion whenever you create a pull request just follow the PULL_REQUEST_TEMPLATE.md
Could you pls mention the type in the PR title & description on why you are making these changes. 👍

@devkapilbansal devkapilbansal added the Status: Changes Requested Changes are required to be done by the PR author. label Mar 8, 2021
@devkapilbansal
Copy link
Member

@Sejalcodes look into what @ashwinijha6 quoted above. It is necessary for all to follow the proper commit message guideline and the Pull Request Template. Without that, PR can't be merged.

devkapilbansal
devkapilbansal suggested changes Mar 8, 2021
View reviewed changes
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in contributing.md file is not yet fixed. Consider changing the link.

mentorship-backend/.github/CONTRIBUTING.md

Line 12 in 479f1c7

* When creating an issue to report a bug in the project, please follow our [bug_report.md](ISSUE_TEMPLATE/bug_report.md) template.

@devkapilbansal devkapilbansal removed the Status: Needs Review PR needs an additional review or a maintainer's review. label Mar 8, 2021
@ashwinijha6
Copy link
Contributor

@devkapilbansal & @vj-codes I'm just confused which is the correct pull request for #1013 this one or this. Could u'll help me out .

@vj-codes
Copy link
Member

vj-codes commented Mar 9, 2021

@ashwinijha6 the merged PR partially solved the issue so this is valid as well
@devkapilbansal the link in contributing.md is created in another PR #1035 , @Sejalcodes as a newcomer wasn't aware it shall be done in the same PR .
(It's fine for this time but should take care next time onwards)

@Sejalcodes
Copy link
Contributor Author

@Sejalcodes just a suggestion whenever you create a pull request just follow the PULL_REQUEST_TEMPLATE.md
Could you pls mention the type in the PR title & description on why you are making these changes. 👍

Yes, okay I added the description too...

@Sejalcodes
Copy link
Contributor Author

The link in contributing.md file is not yet fixed. Consider changing the link.

mentorship-backend/.github/CONTRIBUTING.md

Line 12 in 479f1c7

* When creating an issue to report a bug in the project, please follow our [bug_report.md](ISSUE_TEMPLATE/bug_report.md) template.

I updated the link earlier, however I think that too is not working!...... I wanted to confirm if this is the correct link that needs to be updated "https://github.com/anitab-org/mentorship-backend/blob/develop/.github/ISSUE_TEMPLATE.md"?

@vj-codes
Copy link
Member

vj-codes commented Mar 9, 2021

@Sejalcodes you have added the link in #1035 , don't make any changes in this one
Both are good

@Sejalcodes
Copy link
Contributor Author

@Sejalcodes you have added the link in #1035 , don't make any changes in this one
Both are good

okay, thankyou for letting me know!

@ashwinijha6
Copy link
Contributor

@ashwinijha6 the merged PR partially solved the issue so this is valid as well
@devkapilbansal the link in contributing.md is created in another PR #1035 , @Sejalcodes as a newcomer wasn't aware it shall be done in the same PR .
(It's fine for this time but should take care next time onwards)

Ok I get you @vj-codes 👍

ashwinijha6
ashwinijha6 suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ashwinijha6 ashwinijha6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sejalcodes I wanted you to change the type that is doc in this PR title
Change it to doc: delete ISSUE_TEMPLATE.md & mention some description here ( shown in the screenshot) as to why certain changes need to be done
des

@Sejalcodes Sejalcodes changed the title Delete ISSUE_TEMPLATE.md doc: delete ISSUE_TEMPLATE.md Mar 9, 2021
@Sejalcodes
Copy link
Contributor Author

@Sejalcodes I wanted you to change the type that is doc in this PR title
Change it to doc: delete ISSUE_TEMPLATE.md & mention some description here ( shown in the screenshot) as to why certain changes need to be done
des

Hello, is it okay now? :)

@ashwinijha6
Copy link
Contributor

@Sejalcodes I have approved the PR. Actually I meant to use the PR TEMPLATE but I guess there are 2 PR's related to 1 Issue, So you wanted to keep this as a contintuation. Also I feel that the reason for deleting the ISSUE_TEMPLATE.md file is because they are now on https://github.com/anitab-org/.github, correct me if I'm wrong.

devkapilbansal
devkapilbansal approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devkapilbansal
Copy link
Member

Adding Ready to Merge since this PR don't need testing.

@devkapilbansal devkapilbansal added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Mar 11, 2021
@isabelcosta isabelcosta merged commit 4295459 into anitab-org:develop Mar 14, 2021
@isabelcosta
Copy link
Member

@Sejalcodes congrats on your PR merge 👏🏾

isabelcosta pushed a commit that referenced this pull request Apr 18, 2021
@Sejalcodes @isabelcosta
docs: delete ISSUE_TEMPLATE.md (#1032)
b66f90f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes approved these changes

@ashwinijha6 ashwinijha6 ashwinijha6 approved these changes

@devkapilbansal devkapilbansal devkapilbansal approved these changes

Assignees
No one assigned
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove .github/ISSUE_TEMPLATE folder
5 participants
@Sejalcodes @vj-codes @devkapilbansal @ashwinijha6 @isabelcosta