Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delete .github/ISSUE_TEMPLATE folder #1021

Merged
merged 4 commits into from
Feb 27, 2021

Conversation

s4-2
Copy link
Contributor

@s4-2 s4-2 commented Feb 27, 2021

Description

Fixes #1013

Type of Change:

  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #1021 (ae306d9) into develop (3fc9582) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1021      +/-   ##
===========================================
- Coverage    96.19%   96.18%   -0.01%     
===========================================
  Files          100      100              
  Lines         5438     5426      -12     
===========================================
- Hits          5231     5219      -12     
  Misses         207      207              
Impacted Files Coverage Δ
app/api/models/user.py 100.00% <ø> (ø)
app/api/resources/user.py 89.65% <ø> (-0.25%) ⬇️
...ests/task_comments/test_api_create_task_comment.py 98.27% <100.00%> (ø)
...ests/task_comments/test_api_delete_task_comment.py 98.57% <100.00%> (ø)
tests/task_comments/test_api_get_task_comments.py 97.61% <100.00%> (ø)
...ests/task_comments/test_api_modify_task_comment.py 98.75% <100.00%> (ø)
tests/users/test_api_login.py 97.61% <100.00%> (-0.30%) ⬇️
tests/users/test_api_refresh.py 97.77% <100.00%> (-0.05%) ⬇️

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually learned something new here 🤓 However the issue you are solving is about deleting the .github/ISSUE_TEMPLATE folder completely, because we can use instead the ones from our .github repository.

Can you please delete the folder completely and commit again?
And thank you for working on this!

@@ -1,6 +1,10 @@
---
name: Quality Assurance task
about: Provide a group of test cases for the some parts of the project.
title: ''
labels: enhancement, good first issue, question
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually very interesting, I did not know we could do this 🤓

@isabelcosta isabelcosta added the Status: Changes Requested Changes are required to be done by the PR author. label Feb 27, 2021
@s4-2
Copy link
Contributor Author

s4-2 commented Feb 27, 2021 via email

@s4-2 s4-2 mentioned this pull request Feb 27, 2021
3 tasks
@isabelcosta
Copy link
Member

@s4-2 you can edit these PR changes and commit and push again, no need to create another PR for it. Can you do this on the same branch please?

@isabelcosta
Copy link
Member

@s4-2 let me know if you have any doubt about it, I can still try to help

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work @s4-2 and thank you for following my suggestions :)
Thank you so much for working on this 🤗

@s4-2
Copy link
Contributor Author

s4-2 commented Feb 27, 2021

@isabelcosta I have not yet use push command, can you guide me how I can do this please.

@isabelcosta isabelcosta added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Feb 27, 2021
@isabelcosta isabelcosta changed the title GitHub/issue template docs: delete .github/ISSUE_TEMPLATE folder Feb 27, 2021
@isabelcosta
Copy link
Member

It's already pushed @s4-2 :) you probably did this via GitHub interface and in that case, it is already in the remote repo (same as pushed). your work is done :) I just need another approval and then I can merge.

@s4-2
Copy link
Contributor Author

s4-2 commented Feb 27, 2021

Thank you @isabelcosta, I am happy that you liked my work.
I would like to Thank @epicadk and @isabelcosta for your continuous guidance and help.

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for your contribution @s4-2

@vj-codes
Copy link
Member

@s4-2 just update fixes part of the description with issue no ie #1013 instead of PR no to keep a better track of records.

@vj-codes
Copy link
Member

Adding label ready to merge since no part of code has been changed.

@vj-codes vj-codes added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Feb 27, 2021
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thankyou for your contribution. : )

@isabelcosta isabelcosta merged commit 479f1c7 into anitab-org:develop Feb 27, 2021
b-thebest pushed a commit to b-thebest/mentorship-backend that referenced this pull request Mar 2, 2021
decon-harsh pushed a commit to decon-harsh/mentorship-backend that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .github/ISSUE_TEMPLATE folder
4 participants