-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: delete .github/ISSUE_TEMPLATE folder #1021
Conversation
Update issue templates
Codecov Report
@@ Coverage Diff @@
## develop #1021 +/- ##
===========================================
- Coverage 96.19% 96.18% -0.01%
===========================================
Files 100 100
Lines 5438 5426 -12
===========================================
- Hits 5231 5219 -12
Misses 207 207
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually learned something new here 🤓 However the issue you are solving is about deleting the .github/ISSUE_TEMPLATE
folder completely, because we can use instead the ones from our .github
repository.
Can you please delete the folder completely and commit again?
And thank you for working on this!
@@ -1,6 +1,10 @@ | |||
--- | |||
name: Quality Assurance task | |||
about: Provide a group of test cases for the some parts of the project. | |||
title: '' | |||
labels: enhancement, good first issue, question |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually very interesting, I did not know we could do this 🤓
Okay, I will do it now.
…On Sat, 27 Feb 2021, 23:20 Isabel Costa, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I actually learned something new here 🤓 However the issue you are
solving is about deleting the .github/ISSUE_TEMPLATE folder completely,
because we can use instead the ones from our .github repository.
Can you please delete the folder completely and commit again?
And thank you for working on this!
------------------------------
In .github/ISSUE_TEMPLATE/quality_assurance.md
<#1021 (comment)>
:
> @@ -1,6 +1,10 @@
---
name: Quality Assurance task
about: Provide a group of test cases for the some parts of the project.
+title: ''
+labels: enhancement, good first issue, question
this is actually very interesting, I did not know we could do this 🤓
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1021 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSVRCENM3HQ46PI5IJREJTTBEWGRANCNFSM4YKENOIA>
.
|
@s4-2 you can edit these PR changes and commit and push again, no need to create another PR for it. Can you do this on the same branch please? |
@s4-2 let me know if you have any doubt about it, I can still try to help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great work @s4-2 and thank you for following my suggestions :)
Thank you so much for working on this 🤗
@isabelcosta I have not yet use push command, can you guide me how I can do this please. |
It's already pushed @s4-2 :) you probably did this via GitHub interface and in that case, it is already in the remote repo (same as pushed). your work is done :) I just need another approval and then I can merge. |
Thank you @isabelcosta, I am happy that you liked my work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you for your contribution @s4-2
Adding label ready to merge since no part of code has been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thankyou for your contribution. : )
Description
Fixes #1013
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only