Fix websocket patch #83
Conversation
previously when we detected that patching via descriptors is possible we would patch everything, but websockets. This change adds descriptor patching for websockets. I also fixed existing unit test which was incorrectly written. The test now correctly fails without the patch. Closes angular#81
| @@ -169,7 +169,7 @@ Zone.patchSetClearFn = function (obj, fnNames) { | |||
| }); | |||
| }; | |||
|
|
|||
| Zone.nextId = 1; | |||
| Zone.nextId = 0; | |||
There was a problem hiding this comment.
root zone should still be 1
it feels more natural this way
IgorMinar
force-pushed
the
fix-websocket-patch
branch
from
1d1a290
to
3926e7d
Compare
The original "canPatchViaDescriptor" fix didn't resolve that? :( |
|
@IgorMinar great changes ! wrt id numbering, may be we can cut a bug fix release w/o it (0.4.next) and change it for the next version (0.5) which hopefully will be the "modularized" version ? |
|
@vicb – the API is (in theory) private – do you know of anywhere it's used? |
|
I'm not aware of any usage and I would love to this change. But that is not something we need, it's only cosmetic. So I think it could probably wait a little bit. |
|
Hm, okay. @vicb – can you merge the other commits in this PR and create a new PR with just the root zone id fix? |
|
Today is labor day here, I'm not allowed to work ;) |
|
Commenting on GitHub is working! Go enjoy your holiday :P |
|
The current patch is not correct. I'm fixing it up. |
Is due to #88 and affects only Safari 7.0 but not Safari 7.1. This will be hard to test because I don't have 7.0 and web sockets don't work via SL (BrowserStack might work though). |
|
LGTM, merging. |
No description provided.