Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

WebSocket patching fails on Safari 7.0 for onopen, onmessage, onclose, onerror properties #88

Closed
IgorMinar opened this issue May 1, 2015 · 1 comment

Comments

@IgorMinar
Copy link
Contributor

When zone detects that we can't patch prototype descriptors, we call patchWebSocketProperties which tries to patch onmessage and friends via descriptors on the instance. This works in Chrome <43 but not in Safari 7.0 where even instance descriptors are not configurable.

Potential fix would be to return a proxy object similar to how patchClass works and intercept all of the property getters and setters via the proxy.

@IgorMinar
Copy link
Contributor Author

I should also mention that this is not a problem on Safari 7.1 where instance descriptors are configurable. However SauceLabs only provides us with Safari 7.0 and Safari 8.0, not Safari 7.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant