fix: remove TSC_NONPOLLING_WATCHER env variable and provide default watchOptions #1326
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atchOptions (angular#1323) `TSC_NONPOLLING_WATCHER` was used back in the early days to improve file watcher performance, but it prevents files / directories from being moved / renamed. Since TS now provides built-in option to configure file watcher, this environment variable is no longer needed. See https://www.typescriptlang.org/docs/handbook/configuring-watch.html The watch options used are derived from the user defined options in their `tsconfig` combined with the default options provided to the project service via `setHostConfiguration` ([code reference](https://github.com/microsoft/TypeScript/blob/f7ef1540d3c10fb282d1d433d9f2850b28391169/src/server/editorServices.ts#L2985-L2989)). As noted in the documentation for configuration watch options, the default when no watch options are provided falls back to `fs.watchFile` with `250ms` for any file. This would cause the performance issues as seen in angular#1310. Fixes angular#750
zarend
approved these changes
May 4, 2021
alxhub
approved these changes
May 4, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch version of #1323
TSC_NONPOLLING_WATCHERwas used back in the early days to improvefile watcher performance, but it prevents files / directories from
being moved / renamed.
Since TS now provides built-in option to configure file watcher, this
environment variable is no longer needed.
See https://www.typescriptlang.org/docs/handbook/configuring-watch.html
The watch options used are derived from the user defined options in
their
tsconfigcombined with the default options provided to theproject service via
setHostConfiguration(code reference).
As noted in the documentation for configuration watch options, the
default when no watch options are provided falls back to
fs.watchFilewith
250msfor any file. This would cause the performance issues asseen in #1310.
Fixes #750