Cannot rename/move directories.

[Goobles]

Describe the bug

In windows, the ng language service plugin locks all folder/subfolders of the workspace.

I tracked this lock down with LockHunter.exe:

It points to the VSCode subprocess for angular.ng-template.0.901.3\server.

This lock causes renaming directories to fail with:
Error: EPERM: operation not permitted, rename '<source>' -> '<target>'

To Reproduce

Steps to reproduce the behavior:

1. Open any angular workspace that has subdirectories
2. Rename/move a directory within that workspace

Expected behavior

Folder renaming should work.

Logs

Not applicable.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Version info:

Angular CLI: 9.1.1
Node: 12.11.1     
OS: win32 x64     

Angular: 9.1.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router
Ivy Workspace: No

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.1
@angular-devkit/build-angular     0.901.1
@angular-devkit/build-optimizer   0.901.1
@angular-devkit/build-webpack     0.901.1
@angular-devkit/core              9.1.1
@angular-devkit/schematics        9.1.1
@angular/cdk                      9.2.1
@angular/cli                      9.1.1
@angular/material                 9.2.1
@ngtools/webpack                  9.1.1
@schematics/angular               8.3.25
@schematics/update                0.901.1
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.42.0

[kyliau]

This used to be a problem when we rolled our own tsserver, but we've stopped doing that, and now Angular LS relies completely on stock tsserver for file / project management. I wonder if we could reproduce the same problem using just tsserver.

[kyliau]

One area we need to investigate is whether NON_POLLING_WATCHER is used. It is the default watcher, and is known to be more efficient and avoid problems like this.

[blogcraft]

This happens to me also. Is it related to when finally changing folder, the imports wont update?

[mvanderlee]

Still seeing this in 0.1001.0
Angular language server process holds a lot of locks forever, and I can not rename any directories.

[Info  - 4:52:05 PM] Using typescript/lib/tsserverlibrary v4.0.2 from c:\Users\maste\.vscode\extensions\angular.ng-template-0.1001.0\node_modules\typescript\lib\tsserverlibrary.js
[Info  - 4:52:05 PM] Using @angular/language-service v10.1.1 from c:\Users\maste\.vscode\extensions\angular.ng-template-0.1001.0\server\node_modules\@angular\language-service\bundles\language-service.js

[nischi]

Is there any workaround, its super annoying if the refactor is need to be done by hand.

[blogcraft]

still no solution... 😔

[andrius-pra]

Angular language service use non-pooling directory watchers and it does not allow to rename directories. Currently, it's not possible to change this behavior by .vscode\settings.json or tsconfig.json

[kyliau]

The non-polling watchers are used to improve performance, but now that there's built-in option to configure watch mode, we should remove the environment variable.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

[atscott]

Re-opening since we have to revert commit 17708d4 to address #1310