perf: Avoid making Angular-related decisions for files not in an Angular project #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar project (angular#1259) This commit updates our client-side short-circuit logic to provide an additiona short circuit that avoids tokenizing typescript files when they are not within a project that uses Angular. fixes angular#1237
kyliau
approved these changes
Apr 9, 2021
atscott
added a commit
to atscott/vscode-ng-language-service
that referenced
this pull request
May 5, 2021
I have observed that the performance enhancement introduced in angular#1272 does not work in some situations. It appears that if I attempt to do operations in an external template before the language service is initialized, the template will be identified as not being inside an Angular project. The result of this incorrect determination is that we will not service requests for that file. This commit disables the check by always returning `true`, effectively marking every TS and HTML file as being inside an Angular project. There may be some performance degradation in non-Angular projects as a result due to additional file tokenization of TypeScript files. However, we do still expect this tokenization to be very fast and there should be no observable performance issues. angular#1330
atscott
added a commit
to atscott/vscode-ng-language-service
that referenced
this pull request
May 5, 2021
I have observed that the performance enhancement introduced in angular#1272 does not work in some situations. It appears that if I attempt to do operations in an external template before the language service is initialized, the template will be identified as not being inside an Angular project. The result of this incorrect determination is that we will not service requests for that file. This commit disables the check by always returning `true`, effectively marking every TS and HTML file as being inside an Angular project. There may be some performance degradation in non-Angular projects as a result due to additional file tokenization of TypeScript files. However, we do still expect this tokenization to be very fast and there should be no observable performance issues. angular#1330
atscott
added a commit
to atscott/vscode-ng-language-service
that referenced
this pull request
May 5, 2021
I have observed that the performance enhancement introduced in angular#1272 does not work in some situations. It appears that if I attempt to do operations in an external template before the language service is initialized, the template will be identified as not being inside an Angular project. The result of this incorrect determination is that we will not service requests for that file. This commit disables the check by always returning `true`, effectively marking every TS and HTML file as being inside an Angular project. There may be some performance degradation in non-Angular projects as a result due to additional file tokenization of TypeScript files. However, we do still expect this tokenization to be very fast and there should be no observable performance issues. angular#1330
atscott
added a commit
that referenced
this pull request
May 5, 2021
…1331) I have observed that the performance enhancement introduced in #1272 does not work in some situations. It appears that if I attempt to do operations in an external template before the language service is initialized, the template will be identified as not being inside an Angular project. The result of this incorrect determination is that we will not service requests for that file. This commit disables the check by always returning `true`, effectively marking every TS and HTML file as being inside an Angular project. There may be some performance degradation in non-Angular projects as a result due to additional file tokenization of TypeScript files. However, we do still expect this tokenization to be very fast and there should be no observable performance issues. #1330
atscott
added a commit
that referenced
this pull request
May 5, 2021
…1331) I have observed that the performance enhancement introduced in #1272 does not work in some situations. It appears that if I attempt to do operations in an external template before the language service is initialized, the template will be identified as not being inside an Angular project. The result of this incorrect determination is that we will not service requests for that file. This commit disables the check by always returning `true`, effectively marking every TS and HTML file as being inside an Angular project. There may be some performance degradation in non-Angular projects as a result due to additional file tokenization of TypeScript files. However, we do still expect this tokenization to be very fast and there should be no observable performance issues. #1330 (cherry picked from commit 43bcbb7)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch version of #1259