Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement way for language server to communicate to client that Angular is not in workspace #1237

Closed
atscott opened this issue Mar 30, 2021 · 1 comment · Fixed by #1259
Closed

Implement way for language server to communicate to client that Angular is not in workspace #1237

atscott opened this issue Mar 30, 2021 · 1 comment · Fixed by #1259
Assignees
@atscott
Labels
feature

Comments

@atscott
Copy link
Collaborator

atscott commented Mar 30, 2021

We currently have middleware in the client side that tokenizes typescript files to determine if the position is within an inline template before forwarding the request to the server. This is done for performance reasons and allows us to prevent the server from being a bottleneck for typescript files in these cases. However, this tokenization is done for all typescript files, even in non-Angular projects. We should implement a way to communicate from the server back to the client that Angular was not detected in the workspace and that we should skip the tokenization/short-circuit logic.
@atscott atscott self-assigned this Mar 30, 2021
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 2, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
ce17a31 
…lar project

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 5, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
9bd3b8c 
…lar project

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 5, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
cd6e045 
…lar project

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
@atscott atscott mentioned this issue Apr 5, 2021
Merged
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 5, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
374db85 
…lar project

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 9, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
1561672 
…lar project

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
atscott added a commit that referenced this issue Apr 9, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
d8666d8 
…lar project (#1259)

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes #1237
atscott added a commit to atscott/vscode-ng-language-service that referenced this issue Apr 9, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
e7cabb7 
…lar project (angular#1259)

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes angular#1237
kyliau pushed a commit that referenced this issue Apr 9, 2021
@atscott
perf: Avoid making Angular-related decisions for files not in an Angu…
154cf5e 
…lar project (#1259)

This commit updates our client-side short-circuit logic to provide an
additiona short circuit that avoids tokenizing typescript files when
they are not within a project that uses Angular.

fixes #1237
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atscott atscott

Labels
feature
Projects
None yet
Milestone
No milestone
1 participant
@atscott