feat(elementExplorer): Combine browser.pause with elementExplorer

[hankduan]

• reuse logic for browser.pause for elementExplorer
• introduce browser.enterRepl
• allow customization of driver for elementExplorer
• fix bug where repl cannot return an ElementFinder (related ElementFinders should work as params in executeScript calls #1600)

Closes #1314, #1315

[juliemr]

Let's show help here automatically as well.

[juliemr]

Awesome, looks good overall, just a couple clarification comments.

[juliemr]

And I assume a following PR will change the docs and the element explorer binary?

[hankduan]

I'll send a follow up PR to change the docs. I was thinking of removing the element explorer binary since you can just do 'protractor --elementExplorer'. I can keep the binary too, but it would just be a one-liner. What do you think?

[juliemr]

Let's keep the one liner binary for discoverability.

[hankduan]

Addressed comments.

[juliemr]

Great - let me do one more run-through and actually try it out on my computer and then I'll LGTM.

[hankduan]

Docs: #1717

[juliemr]

Can you change this to

Please use protractor [configFile] [options] --elementExplorer

The order can be very confusing if, for example, you run

protractor --elementExplorer myConfig.js

This will actually ignore myConfig.js because optimist interprets it as the value of elementExplorer.

[hankduan]

fixed.

[juliemr]

LGTM

[hankduan]

merged with fb099de

[tb]

How can I can access test scenario varibles in browser.enterRepl()? In particular I am interested to have access to libs/helpers/page objects loded via require, like: HttpBackend = require('http-backend-proxy')

Is this somehow related to #1607 ?

[hankduan]

@tb I agree it sounds like a good feature to have. However, it is not possible right now since Protractor is running user code (repl code) in a vm. It might be possible to inject relevant helpers/librarys into the vm's context during the set up, but it would look something like context = {foo: 3, bar: function() {}}; browser.enterRepl(context); in other words, a user would need to pass those in. If this is something of use to you, please open a new feature request issue and we can track there.