ElementFinders should work as params in executeScript calls

[gologox]

The following code causes infinite loop on the selector, i.e :
12:15:11.418 INFO - Executing: [find elements: By.selector: p.note])
12:15:11.424 INFO - Done: [find elements: By.selector: p.note]

it('should scroll into an unhindering page view of all checkboxes', function(done) {
    var bottomElement = element.all(by.css('p.note')).last().then(function(element) {
      return element;
    });
      browser.driver.executeScript("arguments[0].scrollIntoView(true);", bottomElement).then(function() {
        done();
      });
  });

or

it('should scroll into an unhindering page view of all checkboxes', function(done) {
    element.all(by.css('p.note')).last().then(function(element) {
      browser.driver.executeScript("arguments[0].scrollIntoView(true);", element).then(function() {
        done();
      });
    });
  });

or

function scrollIntoView(element) {
  arguments[0].scrollIntoView();
}

it('should scroll into an unhindering page view of all checkboxes', function(done) {
    element.all(by.css('p.note')).last().then(function(element) {
      browser.driver.executeScript(scrollIntoView, element).then(function() {
        done();
      });
    });
  });

_browser.executeScript()_ does the same thing. If I remove the execute script, the code no longer loops infinitely through the selector.

_Note: This was working fine prior to the 1.4.0 update from 1.2.0~_

Any ideas?

[juliemr]

This is probably due to f7c3c37 (which is listed as a breaking change in the CHANGELOG)

Fortunately, there's a more concise way to fix this. See an example test at 862a096

Your code would look like:

it('should scroll into an unhindering page view of all checkboxes', function() {
    var bottomElement = element.all(by.css('p.note')).last();
    browser.driver.executeScript("arguments[0].scrollIntoView(true);", bottomElement.getWebElement());
});

[juliemr]

However, I'm leaving this issue open because this is hard to discover and it would be great if you didn't have to use the getWebElement call.

[juliemr]

@mgiambalvo I'm not sure if this works now or not, can you check and let's figure out a workaround if not.

[heathkit]

It works now!