Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Chain promises together in lib/browser.ts #3904

Closed
sjelin opened this issue Dec 30, 2016 · 0 comments · Fixed by Jakub41/Flights-Scraper-CPH-Kastrup#46
Closed

Chain promises together in lib/browser.ts #3904

sjelin opened this issue Dec 30, 2016 · 0 comments · Fixed by Jakub41/Flights-Scraper-CPH-Kastrup#46
Labels
hotlist: polish status: pr pending type: cleanup

Comments

@sjelin
Copy link
Contributor

sjelin commented Dec 30, 2016

There are a few places in lib/browser.ts where we should have chained promises together, but didn't because the control flow handled it for us:

  • In ptorMixin, if setupFn() has a then
  • In .get
  • In .setLocation
  • In .getLocationAbsUrl
  • In .debugger

I may add to this list if I find more.
@sjelin sjelin mentioned this issue Jan 20, 2017
Open
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in lib/browser.ts and return promise …
9c5b326 
…from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Closes angular#3904
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in lib/browser.ts and return promise …
011eb00 
…from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Closes angular#3904
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in lib/browser.ts and return promise …
b8c7856 
…from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Closes angular#3904

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
@sjelin sjelin mentioned this issue Jan 26, 2017
Merged
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in lib/browser.ts and return promise …
9654e03 
…from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Closes angular#3904

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in lib/browser.ts and return promise …
741e412 
…from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Closes angular#3904

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain some promises in lib/browser.ts + return promi…
f7bc538 
…se from `waitForAngularEnabled`

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Part of angular#3904

Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
@sjelin sjelin mentioned this issue Jan 26, 2017
Merged
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in browser.get
1586fe9 
Part of angular#3904
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain some promises in lib/browser.ts + return promi…
665a05e 
…se from `waitForAngularEnabled` (#4021)

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Part of #3904

Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser): chain promises in browser.get
70d73d8 
Closes angular#3904
sjelin added a commit that referenced this issue Jan 27, 2017
@sjelin
feat(browser): chain promises in browser.get (#4017)
77525af 
Closes #3904
sjelin added a commit to sjelin/protractor that referenced this issue Jan 27, 2017
@sjelin
feat(browser): chain some promises in lib/browser.ts + return promi…
33393ca 
…se from `waitForAngularEnabled` (angular#4021)

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Part of angular#3904

Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
@sjelin sjelin closed this as completed in 4e40fb1 Jan 27, 2017
igniteram pushed a commit to igniteram/protractor that referenced this issue Feb 21, 2017
@sjelin @igniteram
feat(browser): chain some promises in lib/browser.ts + return promi…
73c1052 
…se from `waitForAngularEnabled` (angular#4021)

Minor breaking change since `waitForAngularEnabled` no longer returns a boolean

Part of angular#3904

Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR

Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
igniteram pushed a commit to igniteram/protractor that referenced this issue Feb 21, 2017
@sjelin @igniteram
feat(browser): chain promises in browser.get (angular#4017)
92e8eae 
Closes angular#3904
@renovate renovate bot mentioned this issue May 29, 2021
Open
1 task
@renovate renovate bot mentioned this issue Jul 22, 2021
Merged
1 task
bodyduardU pushed a commit to bodyduardU/protractor that referenced this issue Dec 5, 2022
@sjelin
feat(browser): chain promises in browser.get (#4017)
7eb23cc 
Closes angular/protractor#3904
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
hotlist: polish status: pr pending type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency protractor to v7 Jakub41/Flights-Scraper-CPH-Kastrup
1 participant
@sjelin