feat(input): added drop event support #16420
Conversation
src/ng/directive/input.js
Outdated
| @@ -1308,7 +1308,7 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) { | |||
|
|
|||
| // if user modifies input value using context menu in IE, we need "paste" and "cut" events to catch it | |||
There was a problem hiding this comment.
This comment needs updating now 😃
src/ng/directive/input.js
Outdated
| @@ -1308,7 +1308,7 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) { | |||
|
|
|||
| // if user modifies input value using context menu in IE, we need "paste" and "cut" events to catch it | |||
| if ($sniffer.hasEvent('paste')) { | |||
There was a problem hiding this comment.
Do we have to check for drop event support separately? Are there browsers that support one but not the other?
There was a problem hiding this comment.
I can't imagine that they would support drop but not paste. But perhaps the other way around?
There was a problem hiding this comment.
From caniuse.com, it looks like support for event drop is equivalent to support for the paste event.
|
@petebacondarwin , @gkalpak: The assembly has fallen with the comment "I have a colon after the closing parenthesis :): but there are colon ones? |
|
@XFree - hmm, it seems that the commit message check is picking up a commit that is from before your PR: Perhaps try rebasing on master, if you haven't recently? |
XFree
force-pushed
the
feature/1.6.X/input/added-drop-event-support
branch
from
e6ce8f9
to
ac5abfa
Compare
|
@petebacondarwin, done |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
drop event not support
What is the new behavior (if this is a feature change)?
added drop event support
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information: