feat(input): add drop event support (#16420)

angular · Jan 28, 2018 · 5dc0766 · 5dc0766
1 parent 212e513
commit 5dc0766
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js
@@ -1302,9 +1302,9 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
       deferListener(event, this, this.value);
     });
 
-    // if user modifies input value using context menu in IE, we need "paste" and "cut" events to catch it
+    // if user modifies input value using context menu in IE, we need "paste", "cut" and "drop" events to catch it
     if ($sniffer.hasEvent('paste')) {
-      element.on('paste cut', deferListener);
+      element.on('paste cut drop', deferListener);
     }
   }
 

diff --git a/test/ng/directive/inputSpec.js b/test/ng/directive/inputSpec.js
@@ -440,7 +440,7 @@ describe('input', function() {
     }
   });
 
-  describe('"keydown", "paste" and "cut" events', function() {
+  describe('"keydown", "paste", "cut" and "drop" events', function() {
     beforeEach(function() {
       // Force browser to report a lack of an 'input' event
       $sniffer.hasEvent = function(eventName) {
@@ -462,6 +462,18 @@ describe('input', function() {
       expect($rootScope.name).toEqual('mark');
     });
 
+    it('should update the model on "drop" event if the input value changes', function() {
+      var inputElm = helper.compileInput('<input type="text" ng-model="name" name="alias" ng-change="change()" />');
+
+      browserTrigger(inputElm, 'keydown');
+      $browser.defer.flush();
+      expect(inputElm).toBePristine();
+
+      inputElm.val('mark');
+      browserTrigger(inputElm, 'drop');
+      $browser.defer.flush();
+      expect($rootScope.name).toEqual('mark');
+    });
 
     it('should update the model on "cut" event', function() {
       var inputElm = helper.compileInput('<input type="text" ng-model="name" name="alias" ng-change="change()" />');