Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): add support to inline Adobe Fonts #21189

Merged
merged 1 commit into from
Jun 28, 2021
Merged

feat(@angular-devkit/build-angular): add support to inline Adobe Fonts #21189

merged 1 commit into from
Jun 28, 2021

Conversation

alan-agius4
Copy link
Collaborator

With this change we add support to inline external Adobe fonts into the index html, we also add a preconnect hint which helps improve page load speed.

Closes #21186

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Jun 24, 2021
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@alan-agius4 alan-agius4 reopened this Jun 24, 2021
With this change we add support to inline external Adobe fonts into the index html, we also add a `preconnect` hint which helps improve page load speed.

Closes #21186
Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 28, 2021
@alan-agius4 alan-agius4 merged commit 18cfa04 into angular:master Jun 28, 2021
@alan-agius4 alan-agius4 deleted the adobe-typekit branch June 28, 2021 18:22
jessicajaniuk pushed a commit to angular/angular that referenced this pull request Jun 28, 2021
In version 12.1, we included font inlining for Adobe fonts, see: angular/angular-cli#21189

PR Close #42642
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support font inlining for additional fonts
3 participants