Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support font inlining for additional fonts #21186

Closed
1 of 15 tasks
mgechev opened this issue Jun 23, 2021 · 2 comments · Fixed by #21189
Closed
1 of 15 tasks

Support font inlining for additional fonts #21186

mgechev opened this issue Jun 23, 2021 · 2 comments · Fixed by #21189

Comments

@mgechev
Copy link
Member

mgechev commented Jun 23, 2021

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Description

We currently support Google font inlining. Ideally, we'd want to support additional providers - Adobe Typekit, etc...

@alan-agius4
Copy link
Collaborator

Following a convo with @mgechev we decided that for the time being we should add Adobe fonts , previously known as Adobe Typekit.

alan-agius4 added a commit that referenced this issue Jun 28, 2021
With this change we add support to inline external Adobe fonts into the index html, we also add a `preconnect` hint which helps improve page load speed.

Closes #21186
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants