Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): fix app shell schematic failure #11603

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

devoto13
Copy link
Contributor

It fails fails with Chunk cannot be found. error message, when AppModule already has import for RouterModule. The reason is that schematic code was assuming that it only receives InsertChange, but addImportToModule also may return NoopChange, when import is already present.

Fixes #10093

@filipesilva filipesilva requested a review from Brocco July 19, 2018 19:15
@devoto13 devoto13 changed the title fix(@schematics/angular): fix app shel schematic failure fix(@schematics/angular): fix app shell schematic failure Jul 20, 2018
@alan-agius4 alan-agius4 removed the request for review from Brocco September 8, 2018 16:11
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 8, 2018
@kyliau kyliau merged commit a5bb3ce into angular:master Sep 10, 2018
@devoto13 devoto13 deleted the fix-app-shell branch October 1, 2018 21:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng generate appShell throws error "Chunk cannot be found"
4 participants