-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appShell fails if the app already has a RouterModule #12138
Comments
From @cexbrayat on December 7, 2017 1:58 @Brocco maybe I'm missing something but I still reproduce with |
From @Brocco on December 14, 2017 15:2 I will investigate further, re-openeing |
From @EduardoIbarra on March 27, 2018 4:51 Is there a solution for this? I am facing the same problem |
From @PascalPrecht on April 4, 2018 12:50 I'm also running into this with CLI 1.7.3. |
From @lawliet616 on April 11, 2018 9:21 For a workaround, I just simply remove the RouterModule and its import from the app.module.ts, run the ng generate app-shell command, then add the RouterModule back. |
Fixed by #11603 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
From @cexbrayat on November 24, 2017 23:18
Bug Report or Feature Request (mark with an
x
)Area
Versions
Repro steps
Generate a new app
ng new hello
.Edit
app.module.ts
to add aRouterModule
:Add
router-outlet
in index.html.Run unviersal:
ng g universal server-app
Run appShell:
ng g app-shell shell --universal-app serverA-app
The log given by the failure
Copied from original issue: angular/devkit#297
The text was updated successfully, but these errors were encountered: