Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pulse_height_dir path in normalize notebook #210

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Fix pulse_height_dir path in normalize notebook #210

merged 1 commit into from
Aug 13, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #165. Fixes the pulse_height_dir argument in the 4b notebook.

How did you implement your changes

Removes a trailing s.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@alex-l-kong alex-l-kong requested a review from ngreenwald August 13, 2022 03:21
@ngreenwald ngreenwald merged commit d0256a5 into main Aug 13, 2022
@ngreenwald ngreenwald deleted the normalize_arg_fix branch August 13, 2022 16:13
@camisowers camisowers added the bug Something isn't working label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngreenwald ngreenwald ngreenwald approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in argument passed to normalize_image_data
3 participants
@alex-l-kong @ngreenwald @camisowers