Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in argument passed to normalize_image_data #165

Closed
efrancis28 opened this issue Jul 22, 2022 · 2 comments · Fixed by #210
Closed

Typo in argument passed to normalize_image_data #165

efrancis28 opened this issue Jul 22, 2022 · 2 comments · Fixed by #210
Assignees
Labels
bug Something isn't working

Comments

@efrancis28
Copy link

In the notebook for step 4b (normalization) the final code block makes a call to normalize_image_data. One of the arguments passed in is 'pulse_heights_dir' however the function in normalize.py is expecting 'pulse_height_dir' sans 's.' Very minor.

@efrancis28 efrancis28 added the bug Something isn't working label Jul 22, 2022
@ngreenwald
Copy link
Member

Cool, wanna open a PR to fix it? You can create a new branch, make the change, commit the change, then push the branch here. Could be good practice using github. If not no worries, @srivarra can handle it.

@efrancis28
Copy link
Author

efrancis28 commented Jul 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants