You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the notebook for step 4b (normalization) the final code block makes a call to normalize_image_data. One of the arguments passed in is 'pulse_heights_dir' however the function in normalize.py is expecting 'pulse_height_dir' sans 's.' Very minor.
The text was updated successfully, but these errors were encountered:
Cool, wanna open a PR to fix it? You can create a new branch, make the change, commit the change, then push the branch here. Could be good practice using github. If not no worries, @srivarra can handle it.
________________________________
From: Noah F. Greenwald ***@***.***>
Sent: Friday, July 22, 2022 1:08 PM
To: angelolab/toffy ***@***.***>
Cc: Erin Francis McCaffrey ***@***.***>; Author ***@***.***>
Subject: Re: [angelolab/toffy] Typo in argument passed to normalize_image_data (Issue #165)
Cool, wanna open a PR to fix it? You can create a new branch, make the change, commit the change, then push the branch here. Could be good practice using github. If not no worries, @srivarra<https://github.com/srivarra> can handle it.
—
Reply to this email directly, view it on GitHub<#165 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFSNY3ZGY4ZR4YGL4KC6FUDVVL5TNANCNFSM54MQAV7A>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
In the notebook for step 4b (normalization) the final code block makes a call to normalize_image_data. One of the arguments passed in is 'pulse_heights_dir' however the function in normalize.py is expecting 'pulse_height_dir' sans 's.' Very minor.
The text was updated successfully, but these errors were encountered: