fix: default to common platform icons #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 12.35% 12.35%
=======================================
Files 74 74
Lines 1133 1133
Branches 196 195 -1
=======================================
Hits 140 140
Misses 909 909
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrew-codes
force-pushed
the
608
branch
2 times, most recently
from
962d7bf to
52f051e
Compare
When no platform icon is found/published from Playnite, default to ones that are available in Playnite Web; including PlayStation 1-5 and PC. Closes #608
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
## [9.4.3](v9.4.2...v9.4.3) (2024-11-18) ### Bug Fixes * default to common platform icons ([188598b](188598b)), closes [#608](#608) * default to common platform icons ([#635](#635)) ([b7bdf23](b7bdf23)), closes [#608](#608) * incorrect required Playnite API version ([a1a4895](a1a4895)), closes [#623](#623) * incorrect required Playnite API version ([#624](#624)) ([e0b6921](e0b6921)), closes [#623](#623) * unknown sources are PC platform ([9aceb5f](9aceb5f)), closes [#633](#633) * unknown sources are PC platform ([#634](#634)) ([52d5c97](52d5c97)), closes [#633](#633)
|
🎉 This PR is included in version 9.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no platform icon is found/published from Playnite, default to ones that are available in Playnite Web; including PlayStation 1-5 and PC.
Closes #608