Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer manifest has wrong SDK dependency version set #623

Closed
JosefNemec opened this issue Nov 14, 2024 · 4 comments · Fixed by #624
Closed

Installer manifest has wrong SDK dependency version set #623

JosefNemec opened this issue Nov 14, 2024 · 4 comments · Fixed by #624
Assignees
Labels

Comments

@JosefNemec
Copy link

https://raw.githubusercontent.com/andrew-codes/playnite-web/refs/heads/main/apps/PlayniteWebPlugin/src/manifest.yaml

You are referencing 6.11 in the project but manifest specifies 5.6.0, which makes it impossible to be installed via addon browser in Playnite itself, because 5.x SDK is only compatible with old Playnite 9.

@github-project-automation github-project-automation bot moved this to Needs Triage 🗃️ in Playnite-Web Nov 14, 2024
@andrew-codes
Copy link
Owner

Thank you! I wasn't completely certain what value to use. This is good to know and I'll update today. Thank you again!

@JosefNemec
Copy link
Author

It should be a version of Playnite SDK nuget your plugin references.

andrew-codes added a commit that referenced this issue Nov 14, 2024
Closes Installer manifest has wrong SDK dependency version set #623
andrew-codes added a commit that referenced this issue Nov 14, 2024
Closes Installer manifest has wrong SDK dependency version set #623
@andrew-codes
Copy link
Owner

It should be a version of Playnite SDK nuget your plugin references.

Ah ok, that makes sense. Thans for the clarification.

@andrew-codes andrew-codes self-assigned this Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Review 🎥 to Done ✅ in Playnite-Web Nov 14, 2024
github-actions bot pushed a commit that referenced this issue Nov 18, 2024
## [9.4.3](v9.4.2...v9.4.3) (2024-11-18)

### Bug Fixes

* default to common platform icons ([188598b](188598b)), closes [#608](#608)
* default to common platform icons ([#635](#635)) ([b7bdf23](b7bdf23)), closes [#608](#608)
* incorrect required Playnite API version ([a1a4895](a1a4895)), closes [#623](#623)
* incorrect required Playnite API version ([#624](#624)) ([e0b6921](e0b6921)), closes [#623](#623)
* unknown sources are PC platform ([9aceb5f](9aceb5f)), closes [#633](#633)
* unknown sources are PC platform ([#634](#634)) ([52d5c97](52d5c97)), closes [#633](#633)
Copy link

🎉 This issue has been resolved in version 9.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants