Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown sources are PC platform #634

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: unknown sources are PC platform #634

merged 1 commit into from
Nov 18, 2024

Conversation

andrew-codes
Copy link
Owner

An unknown source is most likely a PC platform release. For this reason, default to PC platform when the source is not recognized as another preset source; i.e. PlayStation, Xbox, Nintendo, etc.

Closes #633

An unknown source is most likely a PC platform release. For this reason, default to PC platform when the source is not recognized as another preset source; i.e. PlayStation, Xbox, Nintendo, etc.

Closes #633
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.35%. Comparing base (e0b6921) to head (9aceb5f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   12.35%   12.35%           
=======================================
  Files          74       74           
  Lines        1133     1133           
  Branches      193      195    +2     
=======================================
  Hits          140      140           
  Misses        993      993           
Flag Coverage Δ
component-tests 31.78% <ø> (ø)
unit-tests 9.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrew-codes andrew-codes merged commit 52d5c97 into main Nov 18, 2024
8 checks passed
@andrew-codes andrew-codes deleted the 633 branch November 18, 2024 14:36
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
## [9.4.3](v9.4.2...v9.4.3) (2024-11-18)

### Bug Fixes

* default to common platform icons ([188598b](188598b)), closes [#608](#608)
* default to common platform icons ([#635](#635)) ([b7bdf23](b7bdf23)), closes [#608](#608)
* incorrect required Playnite API version ([a1a4895](a1a4895)), closes [#623](#623)
* incorrect required Playnite API version ([#624](#624)) ([e0b6921](e0b6921)), closes [#623](#623)
* unknown sources are PC platform ([9aceb5f](9aceb5f)), closes [#633](#633)
* unknown sources are PC platform ([#634](#634)) ([52d5c97](52d5c97)), closes [#633](#633)
Copy link

🎉 This PR is included in version 9.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@R1C3R21
Copy link

R1C3R21 commented Dec 8, 2024

Sadly, even after this change I'm not getting any game from my library onto my database. I have tried adding blank games with platforms listed as "PC", "PS1", just in case that it did not accept them, but those get accepted immediately onto my database. There is no error listed anywhere, in fact my logs showcase that it sends all of the games, considering the amount of objects it sends (519).

Personally, I think that as long-term feature request would be to be able from the PWeb's UI add and/or modify the platforms that the server accepts, alongside their specific icon, this would certainly make the list of platforms platform (for a lack of a better word), more flexible.

@andrew-codes
Copy link
Owner Author

Hi @R1C3R21 , can you try the latest 10.0.0? In my testing, the plugin sent all messages, but the Playnite Web app was not getting all of them. In fact, it seemed random as to how many messages it would receive. In 10.0.0, I changed it to batch these messages into one, leaving only the images to be sent individually. I'm wondering if some of these intermittent data missing issues may be related to inconsistent saving of game data from Playnite.

Also, fwiw, I do have long term plans to be able to update game data directly from Playnite Web. :-)

@R1C3R21
Copy link

R1C3R21 commented Dec 8, 2024

Hi @R1C3R21 , can you try the latest 10.0.0? In my testing, the plugin sent all messages, but the Playnite Web app was not getting all of them. In fact, it seemed random as to how many messages it would receive. In 10.0.0, I changed it to batch these messages into one, leaving only the images to be sent individually. I'm wondering if some of these intermittent data missing issues may be related to inconsistent saving of game data from Playnite.

Also, fwiw, I do have long term plans to be able to update game data directly from Playnite Web. :-)

Sorry for not mentioning it, I made those tests with the last version of the extension and server you published 2 hours ago.
I've been following your project since before 2.0, and back when it did not have those regex checks to determine the platform, the games were added completely fine (although it took several attempts to sync all of them).

@R1C3R21
Copy link

R1C3R21 commented Dec 21, 2024

Hi @R1C3R21 , can you try the latest 10.0.0? In my testing, the plugin sent all messages, but the Playnite Web app was not getting all of them. In fact, it seemed random as to how many messages it would receive. In 10.0.0, I changed it to batch these messages into one, leaving only the images to be sent individually. I'm wondering if some of these intermittent data missing issues may be related to inconsistent saving of game data from Playnite.
Also, fwiw, I do have long term plans to be able to update game data directly from Playnite Web. :-)

Sorry for not mentioning it, I made those tests with the last version of the extension and server you published 2 hours ago. I've been following your project since before 2.0, and back when it did not have those regex checks to determine the platform, the games were added completely fine (although it took several attempts to sync all of them).

By the way, I just realized that I forgot to ping you back with my answer, and yes, I have tested it again with the even newer update that you have pushed recently but still no dice. @andrew-codes

@andrew-codes
Copy link
Owner Author

Ok. Thanks for the update. I'll take a look into third and a free other issues this upcoming week.

@andrew-codes
Copy link
Owner Author

@R1C3R21 , do you mind opening an issue to track your problem? If you see one that matches that is already open, then please comment on it. I'll use that to track the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Default unknown platform sources to be PC
2 participants