Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: using token authorization for styles on Github to be able to us… #603

Merged
merged 2 commits into from
Aug 19, 2023
Merged

feat: using token authorization for styles on Github to be able to us… #603

merged 2 commits into from
Aug 19, 2023

Conversation

danygielow
Copy link
Contributor

…e all types of Github tokens

Issues fixed by this pull request:
Fix #602

Proposed changes

  1. Using Token Authorization instead of Basic Authorization when downloading styles from Github

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@andreoliwa
Copy link
Owner

Thank you for the PR!
I'll try this as soon as I can and get back to you.

@andreoliwa
Copy link
Owner

@danygielow I have tested your branch with personal access tokens (both classic and beta), and they still work.

I don't have a GitHub App setup to test manually but I trust it works for you.

I'm merging this.
Thanks again. 🚀

@andreoliwa andreoliwa merged commit 5d23b6c into andreoliwa:develop Aug 19, 2023
github-actions bot pushed a commit that referenced this pull request Aug 19, 2023
@semantic-release-bot
chore(release): 0.34.0 [skip ci]
309379e 
# [0.34.0](v0.33.2...v0.34.0) (2023-08-19)

### Features

* accept all types of GitHub tokens (personal and apps) ([#603](#603)) ([5d23b6c](5d23b6c))
* drop support for Python 3.7 ([65178f3](65178f3))
@github-actions
Copy link

🎉 This PR is included in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Github Apps Access Tokens in Github URLs
2 participants
@danygielow @andreoliwa