Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Github Apps Access Tokens in Github URLs #602

Closed
danygielow opened this issue Jun 9, 2023 · 1 comment · Fixed by #603
Closed

Allow Github Apps Access Tokens in Github URLs #602

danygielow opened this issue Jun 9, 2023 · 1 comment · Fixed by #603
Labels
bug Something isn't working released Feature/fix is released

Comments

@danygielow
Copy link
Contributor

Expected behavior

nitpick should be able to fetch styles from private Github repos with access tokens derived from Github Apps.

Current behavior

Currently only Personal Access Tokens (starting with ghp_) work correctly. Server to Server Tokens (starting with ghs_) don't work and lead to a 404 Not Found.

Steps to reproduce

  1. Register a Github App
  2. Create an Access Token for that Github App
  3. Use that token in a Github URL in nitpick

Possible Solution

Currently the authentication method is a username only Basic Authentication. If a token Authorization header is used, as it is already for getting the default branch, then both Personal Access Tokens and Server to Server Tokens from Github Apps work.
Could be that also now other Access Tokens also work, but I haven't tried them.

Context

We want to use Nitpick in our CI and don't want to use Personal Access Tokens but Github App Access Tokens instead.

Your environment

  • nitpick version used: 0.33.2
@danygielow danygielow added the bug Something isn't working label Jun 9, 2023
@andreoliwa andreoliwa moved this to Triage in Nitpick Roadmap Jun 9, 2023
@andreoliwa andreoliwa moved this from Triage to Upvoted / Requests in Nitpick Roadmap Aug 19, 2023
@github-project-automation github-project-automation bot moved this from Upvoted / Requests to Done in Nitpick Roadmap Aug 19, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Feature/fix is released
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant