Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4. Add copyright and license to .xdc files #1140

Merged
merged 1 commit into from
Jul 25, 2023
Merged

4. Add copyright and license to .xdc files #1140

merged 1 commit into from
Jul 25, 2023

Conversation

IuliaCMoldovan
Copy link
Contributor

Forth PR out of a series of PRs regarding updating the licenses and copyrights in all files. They should be merged in this order.

New format: Copyright (C) year-year Analog Devices, Inc. All rights reserved.

  • The starting year was determined and changed based on git log --follow --format=%ad --date=format:'%Y' $file | tail -1 which returns the first year it was added
  • Adds copyright and license header to all AMD Xilinx board constraint files (.xdc)

@IuliaCMoldovan IuliaCMoldovan requested a review from a team July 10, 2023 07:32
acostina
acostina previously approved these changes Jul 10, 2023
View reviewed changes
StancaPop
StancaPop previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@StancaPop StancaPop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but between the copyright license and the actual text there should be an empty line. In some cases there's no space between them.

@IuliaCMoldovan IuliaCMoldovan mentioned this pull request Jul 21, 2023
Merged
@IuliaCMoldovan
Add copyright and license to .xdc files
b363841 
Signed-off-by: Iulia Moldovan <Iulia.Moldovan@analog.com>
@IuliaCMoldovan IuliaCMoldovan dismissed stale reviews from StancaPop and acostina via b363841 July 24, 2023 14:50
@IuliaCMoldovan
Copy link
Contributor Author

Added an empty line between the header and the code where it was necessary, and removed where there were too many

StancaPop
StancaPop approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@StancaPop StancaPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@IuliaCMoldovan IuliaCMoldovan merged commit 1cac2d8 into master Jul 25, 2023
1 of 2 checks passed
@IuliaCMoldovan IuliaCMoldovan deleted the dev_license_xdc branch July 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina acostina approved these changes

@StancaPop StancaPop StancaPop approved these changes

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IuliaCMoldovan @acostina @StancaPop