Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

GP replicate_self fixes #185

Merged
merged 10 commits into from
Jul 5, 2019
Merged

GP replicate_self fixes #185

merged 10 commits into from
Jul 5, 2019

Conversation

marpulli
Copy link
Contributor

This fixes #183 (but maybe you want to copy kernels in a different way as discussed yesterday). It also fixes a few other issues with cloning this specific GP module and adds tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marpulli
Copy link
Contributor Author

This was a bit premature, once #184 is merged in the tests should pass

@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #185 into develop will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
- Coverage    88.15%   88.09%   -0.06%     
===========================================
  Files           80       80              
  Lines         4085     4108      +23     
  Branches       693      693              
===========================================
+ Hits          3601     3619      +18     
- Misses         310      313       +3     
- Partials       174      176       +2
Impacted Files Coverage Δ
mxfusion/inference/inference_alg.py 94.73% <100%> (+0.05%) ⬆️
mxfusion/modules/gp_modules/gp_regression.py 94.27% <100%> (-1.85%) ⬇️
mxfusion/modules/module.py 80.92% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d4e36...f9f47ad. Read the comment docs.

Copy link
Contributor

@meissnereric meissnereric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Mark.

Is there a reason you only add this for GPRegression and not for SparseGP or SVIGP?

@marpulli
Copy link
Contributor Author

marpulli commented Jul 3, 2019

Laziness mainly. If you don't want to do anything more general (especially for copying kernels?) I can add it to the other GP modules

@marpulli
Copy link
Contributor Author

marpulli commented Jul 5, 2019

Now added fixes + tests for all GP modules

@meissnereric meissnereric merged commit a4e9328 into amzn:develop Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants