Copy over module algorithms correctly #184
Conversation
|
Thanks for this Mark! Will you add the unit test you wrote from #183 to make sure this doesn't regress in the future? Looks like it got missed in the commit. |
|
I can add a unit test but the test in #183 will still fail because kernels aren't copied correctly |
|
Yep, misread the details since they came at the same time! |
Codecov Report
@@ Coverage Diff @@
## develop #184 +/- ##
===========================================
+ Coverage 88.12% 88.15% +0.02%
===========================================
Files 80 80
Lines 4077 4077
Branches 692 692
===========================================
+ Hits 3593 3594 +1
Misses 310 310
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
|
Tests fail on mac builds because mock isn't installed - do you mind having mock as a dependency for tests? |
requirements/test_requirements.txt
Outdated
| @@ -8,3 +8,4 @@ GPy>=1.9.6 | |||
| matplotlib | |||
| mxnet>=1.3 | |||
| mxboard>=0.1.0 | |||
| mock | |||
There was a problem hiding this comment.
Please specify a version number. Just use the version that you have tested working.
There was a problem hiding this comment.
mock>=3.0.5 or mock==3.0.5?
There was a problem hiding this comment.
Please use mock>=3.0.5 as we will not actively maintain the dependency consistence. Setting exact version numbers can easily result in complicated installation failure.
The module algorithms dictionary is expected to be a list containing tuples but after cloning a module this is not the case. This PR fixes that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.