Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add optional generate-job-summary input to input parameters #28

Merged
merged 3 commits into from
Mar 16, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add job summary as action argument
  • Loading branch information
dinisnunes1 committed Mar 13, 2023
commit e22ecd39f812954a019982094a124fb5542cdda5
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ inputs:
required: false
description: 'disabled cache'
default: 'false'
display-summary:
generate-job-summary:
required: false
description: 'display job summary'
default: 'true'
8 changes: 4 additions & 4 deletions dist/cleanup/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/setup/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/cleanup-android.ts
Original file line number Diff line number Diff line change
@@ -15,7 +15,9 @@ async function run(): Promise<void> {
const ndkVersion = core.getInput(constants.INPUT_NDK_VERSION)
const cmakeVersion = core.getInput(constants.INPUT_CMAKE_VERSION)
const cacheDisabled = core.getInput(constants.INPUT_CACHE_DISABLED)
const displayJobSummary = core.getInput(constants.INPUT_JOB_SUMMARY)
const generateJobSummary = core.getInput(
constants.INPUT_GENERATE_JOB_SUMMARY
)

let savedCacheEntry
if (!cacheDisabled) {
@@ -27,7 +29,7 @@ async function run(): Promise<void> {
)
}

if (displayJobSummary) {
if (generateJobSummary) {
await renderSummary(
sdkVersion,
buildToolsVersion,
2 changes: 1 addition & 1 deletion src/constants.ts
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ export const INPUT_NDK_VERSION = 'ndk-version'
export const INPUT_CMAKE_VERSION = 'cmake-version'
export const INPUT_CACHE_DISABLED = 'cache-disabled'

export const INPUT_JOB_SUMMARY = 'job-summary'
export const INPUT_GENERATE_JOB_SUMMARY = 'generate-job-summary'
export const INPUT_JOB_STATUS = 'job-status'

// https://developer.android.com/studio#command-tools