Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add optional generate-job-summary input to input parameters #28

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

dinisnunes1
Copy link
Contributor

@dinisnunes1 dinisnunes1 commented Mar 13, 2023

Issue: Closes #27

Current Problem:
This action is always posting the job summary (attached to the workflow run). This can be useful in some cases, but it also pollutes the workflow page. So it should be optional.
job_summary

This PR solution:
Add an optional parameter generate-job-summary, and only run renderSummary() if this is true (true by default).

Example of how to use it:

If we want to display the job summary on the workflow result

- name: Setup Android SDK
  uses: amyu/setup-android@v2
  with:
    cache-disabled: true
    sdk-version: '31'
    build-tools-version: '30.0.2'
    ndk-version: '21.3.6528147'

If we want to hide the job summary on the workflow result

- name: Setup Android SDK
  uses: amyu/setup-android@v2
  with:
    cache-disabled: true
    sdk-version: '31'
    build-tools-version: '30.0.2'
    ndk-version: '21.3.6528147'
    generate-job-summary: false

@dinisnunes1 dinisnunes1 changed the title [Fix] Add optional job summary input to input parameters [Fix] Add optional generate-job-summary input to input parameters Mar 13, 2023
Copy link
Owner

@amyu amyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER THANKS!

@amyu amyu merged commit 240dd60 into amyu:main Mar 16, 2023
@dinisnunes1 dinisnunes1 deleted the fix/add-optional-summary-input branch March 16, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job summary is always being posted and attached to the workflow run
2 participants