Feature Proposal: Use github action instead travis for CI / CD #617
Assignees
Labels
status:completed
Issue is completed and on master
type:maintenance
A regular maintenance chore or task, including refactors, build system, CI, performance improvements
Comments
|
I will take a look next week once back. |
Golodhros
added
type:maintenance
|
I haven't used GH actions much but I've worked a ton with circleci, I think I could make good progress on this without too much help -- can I pick this up? |
|
Thanks @dorianj , but I think this one requires to access some passwords / token for the project in order to test it end 2 end (e.g upload pypi). I would still prefer to do it myself if it is ok to you. |
|
all the prs are merged and we are 100% on github action now. |
feng-tao
added
status:completed
dorianj
pushed a commit
to dorianj/amundsen
that referenced
this issue
Apr 25, 2021
* feat: Create ColumnType component (amundsen-io#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (amundsen-io#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (amundsen-io#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (amundsen-io#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
feng-tao
pushed a commit
that referenced
this issue
May 7, 2021
* feat: Create ColumnType component (#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this issue
Jun 30, 2022
* feat: Create ColumnType component (amundsen-io#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (amundsen-io#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (amundsen-io#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (amundsen-io#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior or Use Case
Github action is easy to setup and maintained. We should use github action for all CI / CD in the long run instead of travis. Here is an example workflow(amundsen-io/amundsencommon#47).
Service or Ingestion ETL
Possible Implementation
Example Screenshots (if appropriate):
Context
The text was updated successfully, but these errors were encountered: