Add Storybook to the Frontend library #611
Assignees
Labels
Comments
Golodhros
added
type:feature
|
I'm looking into this |
5 tasks
|
This is done |
|
Thanks @dorianj ! |
dorianj
pushed a commit
to dorianj/amundsen
that referenced
this issue
Apr 25, 2021
* feat: Create ColumnType component (amundsen-io#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (amundsen-io#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (amundsen-io#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (amundsen-io#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
feng-tao
pushed a commit
that referenced
this issue
May 7, 2021
* feat: Create ColumnType component (#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this issue
Jun 30, 2022
* feat: Create ColumnType component (amundsen-io#604) * Create ColumnType component Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Update Modal UI Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * feat: Parse column types (amundsen-io#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Cleanup logic Signed-off-by: Tamika Tannis <ttannis@lyft.com> * More cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Lint fix Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix duplicate test name Signed-off-by: Tamika Tannis <ttannis@lyft.com> * style: Improve UI styles and interactions (amundsen-io#617) * Vertically center modal Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Match design font specifications Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Use variables Signed-off-by: Tamika Tannis <ttannis@lyft.com> * test: Improves unit tests for ColumnType + QA fixes (amundsen-io#625) * Parser tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Updates from design qa Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Improve ColumnType tests Signed-off-by: Tamika Tannis <ttannis@lyft.com> * log support Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Code cleanup Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Fix some lint warning Signed-off-by: Tamika Tannis <ttannis@lyft.com> * Betterer update Signed-off-by: Tamika Tannis <ttannis@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All projects create frontend components for their user interfaces. Amundsen has been creating some of these, and reusing others. However, it is not easy to understand what we have created before, the different styles we apply to them and if we have duplicates.
A storybook implementation will help us gather together our presentational components, making it easy to share, develop and evolve our UI, as well as keeping it consistent.
Expected Behavior or Use Case
We will have a storybook page with examples of our components.
Service or Ingestion ETL
Frontend Library
Possible Implementation
Storybook for React
The text was updated successfully, but these errors were encountered: