Refactor AmpContext dependencies for building #8258
Conversation
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to lannka zhouyx
/to cramforce erwinmombay
/to dvoytenko jridgewell
/to alanorozco camelburrito chenshay choumx cvializ ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
| localElement = null; | ||
| wrapped = null; | ||
| }; | ||
| return internalListenImplementation( |
There was a problem hiding this comment.
probably just move this out
There was a problem hiding this comment.
As we discussed offline, the ideal fix would be to split event-helper in two.
However, loadPromise and listenOncePromise are included in 49 different files so I'd rather do that in a follow-up PR :)
(You can check this using grep -ilr -e loadPromise -e listenOncePromise src extensions 3p | wc -l)
Created #8316 to track this.
alanorozco
changed the title
AmpContext for building.
alanorozco
changed the title
AmpContext for building. AmpContext for building
alanorozco
changed the title
AmpContext for building
| localElement = null; | ||
| wrapped = null; | ||
| }; | ||
| return internalListenImplementation( |
There was a problem hiding this comment.
As we discussed offline, the ideal fix would be to split event-helper in two.
However, loadPromise and listenOncePromise are included in 49 different files so I'd rather do that in a follow-up PR :)
(You can check this using grep -ilr -e loadPromise -e listenOncePromise src extensions 3p | wc -l)
Created #8316 to track this.
| * @param {boolean=} opt_capture | ||
| * @return {!UnlistenDef} | ||
| */ | ||
| export function listen(element, eventType, listener, opt_capture) { |
There was a problem hiding this comment.
export {listen} from './event-helper-listen'
* Fix types for AmpContext * Move and split dependencies for ampcontext-lib * Enable type checks for ampcontext-lib
#8087
AmpContext