Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate 3P ads postMessage API to new format #8087

Closed
2 tasks done
lannka opened this issue Mar 13, 2017 · 6 comments
Closed
2 tasks done

Migrate 3P ads postMessage API to new format #8087

lannka opened this issue Mar 13, 2017 · 6 comments
Assignees
@alanorozco
Labels
P1: High Priority WG: monetization
Milestone
Sprint H1 April

Comments

@lannka
Copy link
Contributor

lannka commented Mar 13, 2017 •
edited by alanorozco
Loading

#6829 introduced a new format for the window.context postMessage APIs. We will need to migrate existing 3P ads to the new format.

Remaining items:

  • clean up experiment flag: sentinel-name-change
  • serialize/deserialize messages sent/received by integration.js using the same function as ampcontext API does

/cc @bradfrizzell
@lannka lannka self-assigned this Mar 13, 2017
@lannka
Copy link
Contributor Author

lannka commented Mar 13, 2017

Marked as P1, as it blocks a few other things.

@lannka lannka mentioned this issue Mar 13, 2017
Closed
@lannka lannka added this to the Sprint H2 March milestone Mar 13, 2017
@jasti
Copy link
Contributor

jasti commented Mar 13, 2017

@ampproject/a4a FYI

@bradfrizzell
Copy link
Contributor

I will get this moving as fast as possible, but a heads up that I am at a conference this week, and then I am on vacation until 3/28. Not sure how much I'll get done on this before I get back. How badly is this blocking you?

@lannka
Copy link
Contributor Author

lannka commented Mar 15, 2017

@bradfrizzell no worry, I will take care of it

@lannka lannka mentioned this issue Mar 17, 2017
Merged
@alanorozco alanorozco assigned alanorozco and unassigned lannka Mar 17, 2017
@alanorozco
Copy link
Member

Taking over :)

This was referenced Mar 17, 2017
Closed
Closed
Closed
Merged
This was referenced Mar 24, 2017
Merged
Merged
@alanorozco
Copy link
Member

Should be done. Need to enable feature flag for canary sometime in the future.

@lannka lannka mentioned this issue May 12, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanorozco alanorozco

Labels
P1: High Priority WG: monetization
Projects
None yet
Milestone
Sprint H1 April
Development

No branches or pull requests
5 participants
@alanorozco @jasti @bradfrizzell @lannka @ampwafflebot