Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️ Unskip some tests that no longer fail #39329

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Aug 2, 2023

Fixes #33413
Fixes #35925
Fixes #35966
Fixes #37532
Fixes #38126
Fixes #38720

Ran the CI tests 15 times to make sure these aren't flaky anymore (the first 2 failures for the head commit on this branch are due to temporary tooling hiccups)

This reactives a total of 2347 tests!

@danielrozenberg danielrozenberg marked this pull request as ready for review August 2, 2023 19:53
@danielrozenberg danielrozenberg enabled auto-merge (squash) August 2, 2023 19:53
@danielrozenberg danielrozenberg marked this pull request as draft August 2, 2023 20:01
@danielrozenberg danielrozenberg removed the request for review from erwinmombay August 2, 2023 20:01
@danielrozenberg danielrozenberg force-pushed the unskip-tests branch 23 times, most recently from cc7b05c to b8e85ac Compare August 8, 2023 19:24
@danielrozenberg danielrozenberg force-pushed the unskip-tests branch 2 times, most recently from b9a3186 to 2f2aaba Compare August 9, 2023 17:14
@danielrozenberg danielrozenberg marked this pull request as ready for review August 9, 2023 19:19
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 9, 2023

Hey @alanorozco! These files were changed:

extensions/amp-powr-player/0.1/test/test-amp-powr-player.js
extensions/amp-viqeo-player/0.1/test/test-amp-viqeo-player.js

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/test/test-media-tasks.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment