Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests amp-mowplayer with data-mediaid and amp-ad-network-doubleclick-impl - regular #getAdUrl expands CLIENT_ID in targeting #38720

Closed
danielrozenberg opened this issue Mar 23, 2023 · 1 comment · Fixed by #39329
Closed

Fix flaky tests amp-mowplayer with data-mediaid and amp-ad-network-doubleclick-impl - regular #getAdUrl expands CLIENT_ID in targeting #38720

danielrozenberg opened this issue Mar 23, 2023 · 1 comment · Fixed by #39329
Labels
P2: Soon Type: Bug Type: Testing

Comments

@danielrozenberg
Copy link
Member

danielrozenberg commented Mar 23, 2023 •
edited
Loading

Description

Disabled in #38721

Reproduction Steps

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response
@danielrozenberg
Copy link
Member Author

@ampproject/wg-ads-reviewers @ampproject/wg-components

@danielrozenberg danielrozenberg mentioned this issue Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2: Soon Type: Bug Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

❄️ Unskip some tests that no longer fail danielrozenberg/amphtml
2 participants
@erwinmombay @danielrozenberg