📖 bento-facebook Documentation
#36038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a README.md for 1.0 bento mode.
outside of valid AMP docs.
dmanek
approved these changes
Sep 13, 2021
|
|
||
| ### Web Component | ||
|
|
||
| you must include each Bento component's required CSS library before adding custom styles in order to guarantee proper loading. Or use the lightweight pre-uprgrade styles available inline. See [Layout and Style](#layout-and-style). |
caroqliu
requested changes
Sep 14, 2021
| [example preview="inline" playground="true" imports="amp-facebook"][sourcecode:html] | ||
| <amp-facebook width="552" height="500" | ||
| layout="responsive" | ||
| data-embed-type="comment" |
There was a problem hiding this comment.
Suggested change
| data-embed-type="comment" | |
| data-embed-as="comment" |
Comment on lines
50
to
51
| <!-- TODO(wg-bento): Once available, change src to bento-facebook.js --> | ||
| <script async src="https://cdn.ampproject.org/v0/amp-facebook-1.0.js"></script> |
There was a problem hiding this comment.
I believe this is available now, right @alanorozco ?
Suggested change
| <!-- TODO(wg-bento): Once available, change src to bento-facebook.js --> | |
| <script async src="https://cdn.ampproject.org/v0/amp-facebook-1.0.js"></script> | |
| <script async src="https://cdn.ampproject.org/v0/bento-facebook-1.0.js"></script> |
Comment on lines
61
to
64
| <amp-facebook id="facebook-post" width="552" height="310" | ||
| layout="responsive" | ||
| data-href="https://www.facebook.com/ParksCanada/posts/1712989015384373"> | ||
| </amp-facebook> |
There was a problem hiding this comment.
Please replace all amp-facebook with bento-facebook and remove all width/height/layout attrs
Suggested change
| <amp-facebook id="facebook-post" width="552" height="310" | |
| layout="responsive" | |
| data-href="https://www.facebook.com/ParksCanada/posts/1712989015384373"> | |
| </amp-facebook> | |
| <bento-facebook id="facebook-post" | |
| data-href="https://www.facebook.com/ParksCanada/posts/1712989015384373"> | |
| </bento-facebook> |
Comment on lines
83
to
87
| <amp-facebook id="facebook-video" width="476" height="316" | ||
| layout="responsive" | ||
| data-embed-as="video" | ||
| data-href="https://www.facebook.com/nasaearth/videos/10155187938052139"> | ||
| </amp-facebook> |
There was a problem hiding this comment.
Suggested change
| <amp-facebook id="facebook-video" width="476" height="316" | |
| layout="responsive" | |
| data-embed-as="video" | |
| data-href="https://www.facebook.com/nasaearth/videos/10155187938052139"> | |
| </amp-facebook> | |
| <bento-facebook id="facebook-video" | |
| data-embed-as="video" | |
| data-href="https://www.facebook.com/nasaearth/videos/10155187938052139"> | |
| </bento-facebook> |
Comment on lines
106
to
110
| <amp-facebook id="facebook-comment" width="552" height="500" | ||
| layout="responsive" | ||
| data-embed-type="comment" | ||
| data-href="https://www.facebook.com/zuck/posts/10102735452532991?comment_id=1070233703036185"> | ||
| </amp-facebook> |
There was a problem hiding this comment.
Suggested change
| <amp-facebook id="facebook-comment" width="552" height="500" | |
| layout="responsive" | |
| data-embed-type="comment" | |
| data-href="https://www.facebook.com/zuck/posts/10102735452532991?comment_id=1070233703036185"> | |
| </amp-facebook> | |
| <bento-facebook id="facebook-comment" | |
| data-embed-type="comment" | |
| data-href="https://www.facebook.com/zuck/posts/10102735452532991?comment_id=1070233703036185"> | |
| </bento-facebook> |
Comment on lines
164
to
178
| The value is either `post`, `video` or `comment`. The default is `post`. | ||
|
|
||
| Both posts and videos can be embedded as a post. Setting `data-embed-as="video"` | ||
| for Facebook videos embeds the player of the video, and adds the accompanying | ||
| post card with it. Setting `data-embed-as="post"` ignores the caption card. This | ||
| is done to make sure we are zooming in on videos correctly. | ||
|
|
||
| The `comment` value embeds a single comment (or reply to a comment) on a post. | ||
| This is not to be confused with | ||
| [`amp-facebook-comments`](https://amp.dev/documentation/examples/components/amp-facebook-comments/). | ||
|
|
||
| Check out the documentation for differences between | ||
| [post embeds](https://developers.facebook.com/docs/plugins/embedded-posts), | ||
| [video embeds](https://developers.facebook.com/docs/plugins/embedded-video-player), | ||
| and [comment embeds](https://developers.facebook.com/docs/plugins/embedded-comments). |
There was a problem hiding this comment.
There should be six options total: post, video, comment, comments, like, page
Comment on lines
208
to
211
| ##### title (optional) | ||
|
|
||
| Define a `title` attribute for the component to propagate to the underlying `<iframe>` element. The default value is `"Facebook"`. | ||
|
|
There was a problem hiding this comment.
Please move this attr down to be in alphabetical order
|
|
||
| ##### `embedAs` | ||
|
|
||
| The value is either `post`, `video` or `comment`. The default is `post`. |
There was a problem hiding this comment.
Again, please include all 6 options
| When you are embedding a comment reply, you can optionally also include the | ||
| parent comment of the reply. | ||
|
|
||
| ##### `allowfullscreen` |
There was a problem hiding this comment.
This should be allowFullScreen
Suggested change
| ##### `allowfullscreen` | |
| ##### `allowFullScreen` |
Comment on lines
400
to
403
| ##### `ref` (optional) | ||
|
|
||
| A label for tracking referrals which must be less than 50 characters and can | ||
| contain alphanumeric characters and some punctuation. |
There was a problem hiding this comment.
Suggested change
| ##### `ref` (optional) | |
| A label for tracking referrals which must be less than 50 characters and can | |
| contain alphanumeric characters and some punctuation. | |
| ##### `refLabel` (optional) | |
| A label for tracking referrals which must be less than 50 characters and can | |
| contain alphanumeric characters and some punctuation. |
This is called refLabel for the preact component because ref is a keyword
caroqliu
approved these changes
Sep 29, 2021
Comment on lines
+1
to
+8
| --- | ||
| $category@: layout | ||
| formats: | ||
| - websites | ||
| teaser: | ||
| text: Displays a Facebook post, video, or comment. | ||
| --- | ||
|
|
There was a problem hiding this comment.
Frontmatter isn't needed in the README files
Suggested change
| --- | |
| $category@: layout | |
| formats: | |
| - websites | |
| teaser: | |
| text: Displays a Facebook post, video, or comment. | |
| --- |
AnuragVasanwala
added a commit
to rtCamp/amphtml
that referenced
this pull request
Oct 6, 2021
* tickevents: remove unused enum values (ampproject#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * 📦 Update cimg/openjdk Docker tag to v17 (ampproject#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.57.0 (ampproject#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/graphql to v4.7.0 (ampproject#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️ Migrate `observeWithSharedInOb` to `observeIntersections` (ampproject#36106) * 🏗 Make setup-node step consistent across gh actions (ampproject#36175) * Partially revert "🏗 Parallelize `dist` steps (ampproject#35943)" (ampproject#36176) * Revert "🏗 Parallelize `dist` steps (ampproject#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve ampproject#35920 (ampproject#36103) removed a unlayout call that would cause the image to default to the first slide * ♻️ preact inob: small cleanup (ampproject#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (ampproject#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (ampproject#36113) * Update Yandex & ADFOX amp-ad codes (ampproject#35442) * 🧪Update OT token for attribution-reporting (ampproject#36181) * 🏗 Add `exports` for stylesheets to `package.json` (ampproject#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * ✨ [bento][amp-iframe] Add validator rules for 1.0 (ampproject#36182) * 🚮 Sweep experiments older than 2021-02-01 (ampproject#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (ampproject#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (ampproject#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR ampproject#36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * 📦 Update dependency @octokit/rest to v18.11.2 (ampproject#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (ampproject#36191) * 📦 Update dependency @jest/core to v27.2.3 (ampproject#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.25 (ampproject#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (ampproject#36119) * 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency axios to 0.21.2 [SECURITY] (ampproject#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.13.3 (ampproject#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency tar to v6.1.9 [SECURITY] (ampproject#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (ampproject#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * 🏗 Add nice colors to release tagger logs (ampproject#36200) * log * comment * 📦 Update core devDependencies (ampproject#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/worker-dom to v0.32.0 (ampproject#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency google-closure-library to v20210808 (ampproject#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (ampproject#36202) * 📦 Update dependency chromedriver to v94 (ampproject#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency tar to v6.1.11 (ampproject#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📖 `bento-facebook` Documentation (ampproject#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * 🚮 Clean up dead amp-sidebar code within stories (ampproject#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * 🐛 [amp-story-panning-media] Set width on amp-img el (ampproject#36217) * Set width on amp-img el. * Add height * 📦 Update dependency @octokit/rest to v18.11.3 (ampproject#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.26.1 (ampproject#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/bento-compiler to v0.0.9 (ampproject#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️Don't fetch crypto signature verifier in no-signing (ampproject#36187) * 🐛 Force transfer of `amp-consent` element to the `FixedLayer` (ampproject#36223) Fixes ampproject#36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * 📦 Update core dependencies (ampproject#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.58.0 (ampproject#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/rest to v18.11.4 (ampproject#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (ampproject#36210) * [bento][amp-iframe] changes to publish to npm (ampproject#36190) * 🐛 fix broken link to Preact/React component section in various README (ampproject#36222) * 🏗 release: Update self-hosting support to use amp release (ampproject#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (ampproject#36131) * bento amp-iframe: guard effect from running without a win (ampproject#36241) * 🚀 babel/terser: rename all amp privates with sentinel suffix (ampproject#36143) * configs: Separate user configs from output files (ampproject#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com>
dethstrobe
added a commit
that referenced
this pull request
Apr 12, 2022
* ✨ Initial Commit * ♻️ Attributes mapped to props * ♻️ Base skeleton with references * ♻️ Added build functions and 🖍 CSS * 🧪 Experimental commit for `Gesture` Service * ♻️ Added `Gesture`, `Mouse` and `Keyboard` Service `prettify` is also performed. * Added `"npm": true` for build-system compilation config Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed validator file until rules are added Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed unnecessary example code Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed `copyright` header from all files Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Cleanup * 🚮 Renoved `Services` Services should not be used in the Preact component. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🧪 Experiment commit, 🚮 Remvoed test `console.log` * 🖍 Added and Formatted `JSS` & `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Minor fixes for `JSS` * ♻️ `shouldHintReappear` renamed to more precise name `repeatHint` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🧪 Experimental Test: `DOM` APIs to `JSX` Preact component should not be creating any elements with DOM APIs. Preferring JSX instead. This is an experimental code for my storybook test. * ♻️ Minor fixes and Cleanup * ✨ Added `seekTo` API Function * ♻️ Minor fix to initialise base class * ♻️ Added classes on the JSX node * ⏪ Removed `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `ActionTrust` set for only user interaction `DEFAULT` is needed for user interaction whereas `LOW` events could include things like autoplaying carousels. Thus, `DEFAULT` is recommended! Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Removed unnecessary initialisation and import Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `ImageSlider` prefixed with `Bento` The one exception that can stay `ImageSlider` is Storybooks. So, the Storybooks are still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Preact storybook updated with new prefix `Bento` Preact Storybook `title` should be left as `ImageSlider` so it is still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `classList` changed with `class` Always prefer `class` to `classList`. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `initial-slider-position` type corrected to `number` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Bug fix for `images` and `labels` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Updated storybook examples Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Cleanup unnecessary storybook comment * ♻️ `disable-hint-reappear` renamed as `display-hint-once` in Bento `1.0` The intention is to not have an attribute with a negative name, since enabling or disabling it can be confusing to reason about. On second thought, `repeat-hint` is not a good alternative because it flips the default behaviour when omitted. Let's rename to `display-hint-once` or similar, which has the same default omitted/provided behaviour, but perhaps a clearer name. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ⏪ Changes to markdown reverted and moved to `0.1` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ✨ Added markdown for `1.0` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Fix for Preact Component API Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Minor bug fixes Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Validation check added for `percent` attribute Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Updated use of `DisplayAs` as a component Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `BentoImageSliderApi` namespace renamed to `Api` for precise meaning Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🖍 Added `css` for `1.0`, 🐛 Minor bug fixes and `prettify` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Minor fix for `percent` validation check * ♻️ Removed superfluous trailing argument for `parseFloat` * 🧪 Experimental Code: Image Reference Issue This commit is intended to check and resolve image reference issue mentioned in discussion: #35783 (comment) Use keyboard "left" & "right" arrow key to move bar and slide images. Also, focus on the container to enable keyboard input to the component. * Fix ref issue in DisplayAsWithRef component (#5) * tickevents: remove unused enum values (#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * 📦 Update cimg/openjdk Docker tag to v17 (#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.57.0 (#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/graphql to v4.7.0 (#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️ Migrate `observeWithSharedInOb` to `observeIntersections` (#36106) * 🏗 Make setup-node step consistent across gh actions (#36175) * Partially revert "🏗 Parallelize `dist` steps (#35943)" (#36176) * Revert "🏗 Parallelize `dist` steps (#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve #35920 (#36103) removed a unlayout call that would cause the image to default to the first slide * ♻️ preact inob: small cleanup (#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (#36113) * Update Yandex & ADFOX amp-ad codes (#35442) * 🧪Update OT token for attribution-reporting (#36181) * 🏗 Add `exports` for stylesheets to `package.json` (#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * ✨ [bento][amp-iframe] Add validator rules for 1.0 (#36182) * 🚮 Sweep experiments older than 2021-02-01 (#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR #36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * 📦 Update dependency @octokit/rest to v18.11.2 (#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (#36191) * 📦 Update dependency @jest/core to v27.2.3 (#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.25 (#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (#36119) * 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency axios to 0.21.2 [SECURITY] (#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.13.3 (#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency tar to v6.1.9 [SECURITY] (#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * 🏗 Add nice colors to release tagger logs (#36200) * log * comment * 📦 Update core devDependencies (#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/worker-dom to v0.32.0 (#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency google-closure-library to v20210808 (#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (#36202) * 📦 Update dependency chromedriver to v94 (#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency tar to v6.1.11 (#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📖 `bento-facebook` Documentation (#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * 🚮 Clean up dead amp-sidebar code within stories (#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * 🐛 [amp-story-panning-media] Set width on amp-img el (#36217) * Set width on amp-img el. * Add height * 📦 Update dependency @octokit/rest to v18.11.3 (#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.26.1 (#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/bento-compiler to v0.0.9 (#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️Don't fetch crypto signature verifier in no-signing (#36187) * 🐛 Force transfer of `amp-consent` element to the `FixedLayer` (#36223) Fixes #36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * 📦 Update core dependencies (#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.58.0 (#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/rest to v18.11.4 (#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (#36210) * [bento][amp-iframe] changes to publish to npm (#36190) * 🐛 fix broken link to Preact/React component section in various README (#36222) * 🏗 release: Update self-hosting support to use amp release (#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (#36131) * bento amp-iframe: guard effect from running without a win (#36241) * 🚀 babel/terser: rename all amp privates with sentinel suffix (#36143) * configs: Separate user configs from output files (#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com> * Fix bento slider issues (#12) * Refactor bento amp image slider markup * Fix label styling * Fix hints and slider touch gestures * Add storybook styling for custom label and hints * Remove unneccesary code * Add comments for `containerClass` and `initLogContructor` * Update import path using alias * ♻️ Update alias, update AMP example * 🏗 Update compilation config * 🖍 Fix for `amp-img` size * ♻️ Update image `selector` order * ♻️ Minor fix passing class name * Fix bento image slider misc issues (#14) * Add slot for custom hints and fix label markup * Implement display-hint-once option and cleanup code * Fix LGTM check * Fix LGTM check * Use ContainWrapper for component wrapper * Fix circleCI checks * Add unit test cases for amp-image-slider component * Update initial position attribute in storybook * Add unit test code coverage * Fix flaky test cases * Fix unit test cases * Remove image slider 1.0 example file * Remove unused code * Remove unused code * Fix unlisten event function logic * ♻️ Minor fix, `lint` and `prettify` * ♻️ Update derived class extends using `setSuperClass` * ♻️ Correct dead links in `markdown` * ♻️ Remove `@storybook/addon-knobs` dependency from storybook * ♻️ Allow `src/service/timer-impl.js` dependency * ♻️ Update `Z_INDEX.md` * ♻️ Add check for `initialPosition` and `stepSize` * 🐛 Update `isFiniteNumber` with `isNaN` Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Edi Amin <to.ediamin@gmail.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Deepak Lalwani <deepak.lalwani81@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for Bento-facebook including updating the two amp-facebook.md documents and creating a new README.md file.