🏗 Parallelize dist steps
#35943
Merged
🏗 Parallelize dist steps
#35943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Sep 6, 2021
samouri
changed the title
dist stepsdist steps
rsimha
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
The only cosmetic difference is that the analytics vendor configs are now getting built before the AMP JS entry points and extensions, but that's not an actual problem, and the overall speed increase is excellent to have. LGTM, and thank you for trying this! 👍
DevMahix
pushed a commit
to BroadBandyDev/amphtml
that referenced
this pull request
Sep 9, 2021
DevMahix
pushed a commit
to BroadBandyDev/amphtml
that referenced
this pull request
Sep 9, 2021
rbeckthomas
pushed a commit
to rbeckthomas/amphtml
that referenced
this pull request
Sep 14, 2021
powerivq
added a commit
that referenced
this pull request
Sep 16, 2021
* Broadbandy ad service implementation * Revert serve port * Broadbandy ad service implementation * Revert serve port * 🏗 Misc tsconfig updates (#35787) * update compilerOptions.paths to handle barrel files (index.js) in VSCode * update includes/excludes allowlist/blocklist src files * ♻️ Bento Selector: Simplify logic (#35758) * Bento Selector Option: Give props via JSX * Remove extraneous event handlers * esbuild-exp fix define_experiment_constant (#35800) * SwG Release 0.1.22.181 (#35808) * Improve AMP_CONFIG handling during build (#35773) * applyAmpConfig: also update sourcemaps * no stone unturned: AMP_CONFIG should be part of the wrapper * update comments * update comment + fix bug * another bugfix * allow newline between ; and AMP_CONFIG * retain logs for dist|build * smol clean * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * Update build-system/tasks/prepend-global/index.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * target --> filename Co-authored-by: Raghu Simha <rsimha@amp.dev> * hide placeholder when tweet is succesfully loaded (#35788) * 🚮 Remove IE Support via Polyfills and Conditional Statements (#35317) * Since we are not using the data, lets remove it * Remove all isIE checks and polyfills only used by IE * Remove URL changes * Integration tests were looking for IE specifics * remove transparent img, and ie tests * Skip all tests on IE, this functionality will be removed by the infra team following success * try using user agent directy in test configuration * Fix * Feedback on describe tests not needing configuration now * Remove unused files again * Fix build before main is repaired * 🏗🚮 Remove all IE11 infrastructure code paths (#35341) * Revert "Improve AMP_CONFIG handling during build (#35773)" (#35819) * ♻️ Verizon media yahoo components merge (#35797) * Merged the VerizonMedia ad component into the yahoo component * Fixed documentation formatting issues. * 🐛 [Amp story] Catch ScreenOrientation.lock promise (#35767) * Catch for promise. * Update comment. * Send e. * 🐛[Amp story] Add position scope to attachment-content wrapper (#35786) * Add position to attachment-content wrapper. * whitespace * remove re-export and update MessageType imports (#35817) * Wrap all play calls in catch handler (#35811) * Wrap all play calls in catch handler * Introduce playIgnoringError * Fix type * Fix undefined return case * [amp-iframe] Wrap iframe in shadow DOM and ContainWrapper (#35774) * build-system: fix infinite loop caused by watching css in npm dist folders. (#35827) * Change amp-sticky-ad-to-amp-ad name to avoid trigging the old experiment unintentionally (#35779) * amp GAM support added (#35782) * add policy attributes * add owners * update files for Owners. * Revert file * added GAM implementation * removed policy attribute * removed policy attribute description * changed attribute name and corrected indentation * indentation corrected * new line added at last * 🏗 Simplify release tracker issue template (#35825) * update * more * . * fix some types (#35832) * ie deprecation/bugfix: remove isIe check (#35833) * Disable EsbuildCompilation experiment. (#35814) * ✨ Action `toggleChecked()` (#35795) * Update amp-actions-and-events.md * Update amp-email-actions-and-events.md * Update standard-actions.amp.html * Update scroll-component.js * Update action-impl.js * Update standard-actions-impl.js * Update test-action.js * Update test-standard-actions.js * Update test-standard-actions.js * Update amp-actions-and-events.md * Update amp-email-actions-and-events.md * Update standard-actions.amp.html * Update scroll-component.js * Update action-impl.js * Update standard-actions-impl.js * Update test-action.js * Update test-standard-actions.js * Fix error Delete `⏎` prettier/prettier * Update amp-actions-and-events.md * Update amp-email-actions-and-events.md * Update standard-actions.amp.html * revert for attribution * revert for attribution * revert for attribution * Update docs/spec/amp-actions-and-events.md Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Update docs/spec/amp-email-actions-and-events.md Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Update examples/standard-actions.amp.html Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Update test-standard-actions.js * Update test-standard-actions.js * Update test-standard-actions.js * Fix error Insert `,` prettier/prettier Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Add TrafficStars ad network support (#35836) * 📦 Update dependency esbuild to v0.12.11 (#35058) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency prettier to v2.3.2 (#35059) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.24 (#35840) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ✨ `amp-date-display`: Support `timeZoneName` and `timeZoneNameShort` (#35828) Fixes #35812 Adds support for template variables `{{timeZoneName}}` and `{{timeZoneNameShort}}`. Added to Classic (`0.1`) and Bento (`1.0`) versions. * 📦 Update dependency prismjs to 1.24.0 [SECURITY] (#35082) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency path-parse to 1.0.7 [SECURITY] (#35600) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (#35842) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update subpackage devDependencies (#35035) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-jsdoc to v36 (#35392) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update core devDependencies (#34748) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update validator devDependencies (#35841) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update build-system devDependencies (major) (#35377) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency jszip to 3.7.0 [SECURITY] (#35599) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update build-system devDependencies (#34993) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * Remove amp-unresolved when extension downloads in R1 (#35845) * Remove amp-unresolved when extension downloads in R1 * test * Lint * 🏗 Ensure every babel invocation has a name (#35851) * 🏗 Replace `globby` with `fast-glob` (#35846) * Remove IE11 support from supported browsers (#35865) * mode: collapse definitions of localDev and test (#35823) * mode: collapse localDev and test * fix tests * video-iframe-integration: test agnosticism. * bring back isProd for DCE * remove isLocalDev from core/mode * getMode override --> AMP_CONFIG override. * Remove getIntersectionChangeElementLayoutBox from amp-iframe. (#35860) * Find sizer and apply slot before `layoutCallback` (#35784) * Apply sizer slot in `buildInternal` * Use optional chain in `applyStaticLayout` * 📖 `bento-twitter` documentation (#35847) * Copy to 0.1 subdir * Edit existing documentation * Create readme * 🖍 Fix displaying hero images over blurry image placeholder (#35759) * Fix displaying hero images over blurry image placeholder This is a second attempt at fixing #32387. The first attempt improperly used `.i-amphtml-ssr` (a class selector), when it should have been `[i-amphtml-ssr]` (a property selector). * Update z-index doc * 🐛 [Amp story page attachment] Propagate title attribute to draggable drawer header (#35863) * Propogate title attribute to header. * Only build title element if title is defined. * Validator rollup (#35882) * cl/392962279 Allow style in noscript. * cl/393187930 Make no-js case valid. * cl/393885470 Remove notice from CSS/Doc length tests. Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> * Remove "for the specified Twitter id" (#35887) * Sync for validator cpp engine and cpp htmlparser (#35885) * Make no-js case valid. The basic structure of the change is to set up a series of requires/satisfies pairs: - Extension js requires v0.js (this is the only code change). - amp-pixel, amp-img, and amp-layout, which have no extension js, likewise require v0.js - non-transformed v0.js requires style boilerplate and the noscript variant (transformed does not). Then we remove the mandatory bits on all of these tags. They are no longer globally mandatory, they are only conditionally mandatory. PiperOrigin-RevId: 393187930 * Remove notice for CSS/Doc length tests. PiperOrigin-RevId: 393885470 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> * Make `compiler.js` runnable within a node.js environment (#35849) * 🐛[`amp-tiktok`] Fix CLS bug. (#35850) * [`amp-tiktok`] Fix CLS issue caused by promise failing to resolve. * [`amp-tiktok`] Add Tests for CLS fix. * [`amp-tiktok`] Update unit tests to cover cls fix case. * [`amp-tiktok`] Remove trailing whitespaces. * ♻️ Remove use of `.find` (#35884) - Fixes compatibility in old browsers that don't support `.find()` - Fixes ampproject/error-reporting#103 * 📦 Update build-system devDependencies (#35856) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.25.1 (#35858) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * Skip new test failures after Chrome93 release (#35900) * 🐛 Use `/register` for Storybook addons (#35890) Preact environment had been updated to this module path, but the AMP environment had not. * ⏮ Rollback `timeZoneName` changes (#35895) For cherry-pick #35892 * Fix child identifiers in Doubleclick SRA IUs. (#35891) * 🏗 Cut a new nightly branch using CircleCI's scheduled jobs (dry run) (#35878) * RTC vendors: add ConsentMetadata to Prebid Server (#33899) Adding gdpr_applies, consent_type, and addtl_consent to Rubicon and AppNexus Prebid Server RTC strings as followup to #30006. Adding @SyntaxNode as FYI for AppNexus. * Revert "⏮ Rollback `timeZoneName` changes (#35895)" (#35911) This reverts commit 017c5a8. * 🏗 Alias `amp-*.js` binaries as `bento-*.js` (#35880) `amp-*.js` binaries for Bento-compatible extensions provide an `<amp-*>` element that can be used **with** `v0.js`, and a `<bento-*>` element that can be used **without** `v0.js`. We'd like that Bento elements are used from `bento-*.js` in Bento mode. This unblocks release since we'll be able to include the scripts in Bento mode using the correct URL. Eventually, this binary will only provide the Bento element, while `amp-*.js` will provide only an AMP element. In the meantime, we alias the multiple-compatibility binary so that `bento-*.js` can be used as soon as possible. * SwG Release 0.1.22.182 (#35919) * Revert "mode: collapse definitions of localDev and test (#35823)" (#35918) This reverts commit 59a07a3. * ♻️ [Story performance] Simplify templates CSS by using attr instead of class (#35861) * Changed classes for template attr * Simplified rules * Fixed some comments * Remove unused template * Reverted pan demo to image * Removed unused const * Added CTA Migration page-outlink experiment (#35867) * Added CTA Migration page-outlink experiment, added logic to have it load during the Promise chain in the layout callback * fixed some circleCI errors * fixed some nits * refactored cta migration and added non-hardcoded values * fixed cricleci spacing issues * fixed cricleci spacing issues * Added description and re-comtting due to circleCI * Added description and re-comtting due to circleCI * Fixed more code review nits * Fixed layout callback unit test * Added back in code-breaking refactor * will open new PR to fix page-attachment prod bug * fixed main merge * renamed the expirement to make it clear it was associated with ads * 🐛 Toggle placeholders/fallbacks properly on Bento components (#35821) * create centralized hooks for onLoad/onLoading/onError in PreactBaseElement * update instances where components used their own (similar) hooks * toggle placeholders for bento components with dynamic content * update storybook stories to demonstrate placeholders/fallbacks * update closure typings * update docs * Move nightly branch cut job from CircleCI to GitHub Actions (#35909) * 🐛 [amp-video-docking] Fix issue hiding docked player during scroll on mobile (#35839) Test-Case: - Start via `amp --extensions=amp-video-iframe,amp-video-docking` - Open http://localhost:8000/examples/article-with-docked-video.html with the iOS simulator - Play first video in article - Scroll down so that the player is docked - Now scroll further down and then quickly up so that the URL bar is shown again - Result => dock gets hidden This pull request fixes the problem by only checking whether the width changed on resize to decide whether the player should be undocked. Also see this comment, which also explains the bug: #27825 (comment) cc @alanorozco * Skip flaky test (#35926) * ♻️ Use Storybook `args` (first round) (#35915) Partial for #35923 This is the first step to replace Storybook Knobs (deprecated)[1] with Controls[2]. [1] https://www.npmjs.com/package/@storybook/addon-knobs [2] https://storybook.js.org/docs/react/essentials/controls We have over 60 Storybook files. I'm submitting the PRs in multiple rounds to prevent overwhelming the reviewers. In summary: 1. Installs `@storybook/addon-controls` 2. Updates template for generated Stories. 3. Updates 15 Stories across extensions. * 🐛 [Amp story page outlink] Default outlink color and warning (#35866) * Default outlink color. * Remove unnecessary if block. * 🐛 [Amp story] Prevent pointer events on images (#35929) * Prevent pointer events on images. * Update comment. * Select images in grid layer. * cl/394490119 Fix a bug where the CSS parser was not correctly accounting for the possibility of calc() in the media expression. (#35937) * 🏗 Visual diff updates and fixes (#35942) * Update visual diff's Chrome version to 91.0.4472.0 * Remove page-preparation snippets that are now included in Percy's serializer library * :%s/.percyCss/.percyCSS/ * Remove <noscript> elements from doc/iframes * Restore <canvas> → <img> freezer * Bento Carousel: Restore default `rtl` values (#35924) * 🐛 [Attachment Forms] Remove the soft keyboard from view when the page attachment is closed (#35798) * Remove focus from elements when closing the page attachment * Hide page attachments when the window has resized and the drawer is closed * Prettier * Adding local files for testing * Rename unfocusChildElements_() to dismissSoftKeyboard_() * Reset the story's scroll position instead of hiding the attachment * Prettier * Remove demo files * Add back demo example files for testing * Rename dismissSoftKeyboard_ to blurFocusedEl_ and clarify keyboard-related comments * Simplify the demo * Fold the attachment-forms.html examples into the existing attachment.html example file * Update the ID of the second example * Update blur the active element instead of using a query selector * Set the demo's paragraph font size so that the text doesn't resize when the soft keyboard opens * Add a visual test to confirm that the soft keyboard closes along with attachment close * Add missing comma * Remove trailing whitespace * Comment updates; removed new paragraph element to dismiss the attachment by tapping the spacer instead * Use p element again in the visual diff test, since the spacer element is not visible on desktop * Use .i-amphtml-story-page-attachment-close-button to dismiss the attachment instead of a p element * Move the form presence visual tests to be adjacent to each other * Remove publisher domain text within the form presence visual diff tests * Formatting fixes * Formatting fixes * Use a dummy domain name instead of removing it altogether * Rename `BaseCarousel` as `BentoBaseCarousel` (#35935) * Rename `Twitter` to `BentoTwitter` (#35933) * 📖 Update Storybook documentation in `testing.md` (#35944) Listed commands were outdated. Added some more detail and changed some phrasing. * 📖 [Story videos] Add video documentation for Google cache (#35609) * Add video documentation * More detail * Added section on amp-story * Update extensions/amp-story/amp-story.md Co-authored-by: Gabriel Majoulet <gmajoulet@google.com> * Updating documentation with approved language * Simplify amp-story.md Co-authored-by: Gabriel Majoulet <gmajoulet@google.com> * Update release-tagger.yml (#35946) * Add TrafficStars ad network integration (#35922) * Add trafficstars ad network integration * Remove integration from 3p * Sync for validator cpp engine and cpp htmlparser (#35952) * Fix a bug where the CSS parser was not correctly accounting for the possibility of calc() in the media expression. PiperOrigin-RevId: 394490119 * Remove .proto.h from parse-css.cc imports. The .pb.h version works with bazel. PiperOrigin-RevId: 394774272 * ✨ Ssp params extended (#35957) Co-authored-by: PetrBlaha <petr.blaha@firma.seznam.cz> * refactor(amp-accordion): (#35864) * update (p)react component names * update component.type * * rename DateDisplay -> BentoDateDisplay (#35875) * rename component.type * ensure css is published * 🐛 Followup fix from BaseCarousel → BentoBaseCarousel rename (#35968) * rename `Instagram` to `BentoInstagram` (#35949) * BentoFitText title to 'FitText' (#35972) * 🏗 Parallelize `dist` steps (#35943) * 📖 BentoBaseCarousel README code fixes (#35973) * 🏗 Fix `make release` bug for release tagger (#35947) * get ref instead of release * release note tweaks * * rename InlineGallery -> BentoInlineGallery (#35876) * rename Pagination -> BentoInlineGalleryPagination * rename Thumbnails -> BentoInlineGalleryThumbnails * update component.type * * rename DateCountdown -> BentoDateCountdown (#35874) * update component.type * ensure css is published * refactor(amp-stream-gallery): rename StreamGallery -> BentoStreamGallery (#35879) * Update Storybook template to differentiate between `Foo` and `BentoFoo` (#35974) * Update Storybook template * Set prefix in code, not template replacememt * Set experiment to 1 (#35970) * Clean up some small linter issues with validator files. (#35982) * Rename `Instagram` to `BentoInstagram` (#35948) * Rename EmbedlyCard -> BentoEmbedlyCard (#35977) * Make amp-form failure message developer-friendlier (#35964) This can happen whenever the XHR proxy server returns an error and doesn't include the HTML to render the submit-failure template (e.g., AMP CORS failure, unreacheable proxy). Sever-side rendering of template is an implementation detail of AMP for Email that developers shouldn't care about so it makes sense to change this to one that would make more sense for developers. * added refresh interval for amp-ad blocks in the apester-media (#35961) 🐛 Bug fix. 1) Added refresh interval for amp-ad blocks in the amp-apester-media 2) Moved inline styles into class for amp-apester-media bottom ad block with the fix of centering this block. * 📖 Warn when using a consent promptUI that contains an iframe (#35986) Because of the rendering cycle, a `promptUI` that contains an `amp-iframe` may cause content flashing. `promptUISrc` can be used instead and prevent that issue. * ♻️ Use Storybook `args` (second round) (#35930) Partial for #35923 * 📖 Add Storybook Style Recommendations (#35945) * 🖍 [Attachment Forms] Update the style of the attachment header text (#35862) * Make the publisher domain text lighter than the attachment's title text * Uncomment out changes * Increase the size of the attachment's title font * Make the attachment title and domain URL bolder, and decrease the distance between them * Place the domain label above the title so that the title doesn't conceal part of the domain * Increase bottom padding of header to ensure domain label doesn't overlap attachment content * 🏗 Update Storybook forbidden terms (#35991) 1. Move `withA11y` entry to `forbiddenTermsGlobal`. It wasn't targetting the right files previously. 2. Add `@storybook/addon-knobs` since it's deprecated. Partial for #35923 * SwG Release 0.1.22.183 (#35997) * ♻️ Rename `Brightcove` to `BentoBrightcove` (#35994) * Pin CircleCI's Chrome version (#35916) This is to prevent new stable releases of Chrome from causing test failures. Eg, the Chrome 93 release caused several tests failures that made `main` red until the tests were skipped. This delayed a cherry-pick we're working on, since the new release (on on top of old code) also picked up Chrome 93. This should be updated regularly, hopefully with a chance to test Chrome releases during the Beta period so we can proactively fix issues. Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> * ♻️ Provide BentoVideo (#35993) * ♻️ Rename `Vimeo` to `BentoVimeo` (#35995) * ♻️ Rename `Youtube` to `BentoYoutube` (#35996) * 🐛 [Story animations] Fix prerender resume animation (#35987) * Add try catch * Changed PR number to match PR * 🏗 Enable `npm` for `amp-video` (#34819) * 📖 Add instructions to reproduce validator tests (#35980) * remove editor ignore file * revert register integration * remove unused import * change import order * prettify code Co-authored-by: Mahir <mahir@techwave.io> Co-authored-by: tijl verbert <tijl.verbert@gmail.com> Co-authored-by: DevMahix <mahir_b@msn.com> Co-authored-by: Keshav Varadachari <keshavvi@google.com> Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: mmmicedcoffee <1164097+mmmicedcoffee@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> Co-authored-by: oath-jac <45564796+oath-jac@users.noreply.github.com> Co-authored-by: Philip Bell <philip.hunter.bell@gmail.com> Co-authored-by: Justin Ridgewell <jridgewell@google.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Shihua Zheng <powerivq@users.noreply.github.com> Co-authored-by: ColombiaOnline <sandeep.saini1@timesinternet.in> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Riley Jones <78179109+rileyajones@users.noreply.github.com> Co-authored-by: anrghg <88852183+anrghg@users.noreply.github.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Ilya Shabanov <ishaba@me.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Michael Rybak <michaelrybak@google.com> Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Khoi Doan <khoid@google.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: bretg <bgorsline@gmail.com> Co-authored-by: Chris Antaki <ChrisAntaki@gmail.com> Co-authored-by: Matias Szylkowski <mszylkowski@google.com> Co-authored-by: Jonathan <jshamble@users.noreply.github.com> Co-authored-by: Tobias von Klipstein <tobias@klpstn.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Gabriel Majoulet <gmajoulet@google.com> Co-authored-by: PetrBlaha <petrblahamail@gmail.com> Co-authored-by: PetrBlaha <petr.blaha@firma.seznam.cz> Co-authored-by: Su Zhang (張甦) <me@zhang.su> Co-authored-by: Oleksandr Golovatyi <golovatuy@gmail.com> Co-authored-by: Ricky Hartmann <hartmannr76@gmail.com> Co-authored-by: Boxiao Cao <9083193+antiphoton@users.noreply.github.com>
danielrozenberg
added a commit
to danielrozenberg/amphtml
that referenced
this pull request
Sep 27, 2021
This reverts commit 1e2c808.
danielrozenberg
added a commit
that referenced
this pull request
Sep 27, 2021
AnuragVasanwala
added a commit
to rtCamp/amphtml
that referenced
this pull request
Oct 6, 2021
* tickevents: remove unused enum values (ampproject#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * 📦 Update cimg/openjdk Docker tag to v17 (ampproject#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.57.0 (ampproject#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/graphql to v4.7.0 (ampproject#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️ Migrate `observeWithSharedInOb` to `observeIntersections` (ampproject#36106) * 🏗 Make setup-node step consistent across gh actions (ampproject#36175) * Partially revert "🏗 Parallelize `dist` steps (ampproject#35943)" (ampproject#36176) * Revert "🏗 Parallelize `dist` steps (ampproject#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve ampproject#35920 (ampproject#36103) removed a unlayout call that would cause the image to default to the first slide * ♻️ preact inob: small cleanup (ampproject#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (ampproject#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (ampproject#36113) * Update Yandex & ADFOX amp-ad codes (ampproject#35442) * 🧪Update OT token for attribution-reporting (ampproject#36181) * 🏗 Add `exports` for stylesheets to `package.json` (ampproject#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * ✨ [bento][amp-iframe] Add validator rules for 1.0 (ampproject#36182) * 🚮 Sweep experiments older than 2021-02-01 (ampproject#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (ampproject#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (ampproject#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR ampproject#36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * 📦 Update dependency @octokit/rest to v18.11.2 (ampproject#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (ampproject#36191) * 📦 Update dependency @jest/core to v27.2.3 (ampproject#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.25 (ampproject#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (ampproject#36119) * 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency axios to 0.21.2 [SECURITY] (ampproject#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.13.3 (ampproject#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency tar to v6.1.9 [SECURITY] (ampproject#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (ampproject#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * 🏗 Add nice colors to release tagger logs (ampproject#36200) * log * comment * 📦 Update core devDependencies (ampproject#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/worker-dom to v0.32.0 (ampproject#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency google-closure-library to v20210808 (ampproject#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (ampproject#36202) * 📦 Update dependency chromedriver to v94 (ampproject#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency tar to v6.1.11 (ampproject#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📖 `bento-facebook` Documentation (ampproject#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * 🚮 Clean up dead amp-sidebar code within stories (ampproject#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * 🐛 [amp-story-panning-media] Set width on amp-img el (ampproject#36217) * Set width on amp-img el. * Add height * 📦 Update dependency @octokit/rest to v18.11.3 (ampproject#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.26.1 (ampproject#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/bento-compiler to v0.0.9 (ampproject#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️Don't fetch crypto signature verifier in no-signing (ampproject#36187) * 🐛 Force transfer of `amp-consent` element to the `FixedLayer` (ampproject#36223) Fixes ampproject#36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * 📦 Update core dependencies (ampproject#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.58.0 (ampproject#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/rest to v18.11.4 (ampproject#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (ampproject#36210) * [bento][amp-iframe] changes to publish to npm (ampproject#36190) * 🐛 fix broken link to Preact/React component section in various README (ampproject#36222) * 🏗 release: Update self-hosting support to use amp release (ampproject#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (ampproject#36131) * bento amp-iframe: guard effect from running without a win (ampproject#36241) * 🚀 babel/terser: rename all amp privates with sentinel suffix (ampproject#36143) * configs: Separate user configs from output files (ampproject#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com>
dethstrobe
added a commit
that referenced
this pull request
Apr 12, 2022
* ✨ Initial Commit * ♻️ Attributes mapped to props * ♻️ Base skeleton with references * ♻️ Added build functions and 🖍 CSS * 🧪 Experimental commit for `Gesture` Service * ♻️ Added `Gesture`, `Mouse` and `Keyboard` Service `prettify` is also performed. * Added `"npm": true` for build-system compilation config Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed validator file until rules are added Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed unnecessary example code Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Removed `copyright` header from all files Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Cleanup * 🚮 Renoved `Services` Services should not be used in the Preact component. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🧪 Experiment commit, 🚮 Remvoed test `console.log` * 🖍 Added and Formatted `JSS` & `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Minor fixes for `JSS` * ♻️ `shouldHintReappear` renamed to more precise name `repeatHint` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🧪 Experimental Test: `DOM` APIs to `JSX` Preact component should not be creating any elements with DOM APIs. Preferring JSX instead. This is an experimental code for my storybook test. * ♻️ Minor fixes and Cleanup * ✨ Added `seekTo` API Function * ♻️ Minor fix to initialise base class * ♻️ Added classes on the JSX node * ⏪ Removed `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `ActionTrust` set for only user interaction `DEFAULT` is needed for user interaction whereas `LOW` events could include things like autoplaying carousels. Thus, `DEFAULT` is recommended! Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Removed unnecessary initialisation and import Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `ImageSlider` prefixed with `Bento` The one exception that can stay `ImageSlider` is Storybooks. So, the Storybooks are still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Preact storybook updated with new prefix `Bento` Preact Storybook `title` should be left as `ImageSlider` so it is still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `classList` changed with `class` Always prefer `class` to `classList`. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `initial-slider-position` type corrected to `number` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Bug fix for `images` and `labels` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Updated storybook examples Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🚮 Cleanup unnecessary storybook comment * ♻️ `disable-hint-reappear` renamed as `display-hint-once` in Bento `1.0` The intention is to not have an attribute with a negative name, since enabling or disabling it can be confusing to reason about. On second thought, `repeat-hint` is not a good alternative because it flips the default behaviour when omitted. Let's rename to `display-hint-once` or similar, which has the same default omitted/provided behaviour, but perhaps a clearer name. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ⏪ Changes to markdown reverted and moved to `0.1` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ✨ Added markdown for `1.0` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Fix for Preact Component API Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🐛 Minor bug fixes Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Validation check added for `percent` attribute Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Updated use of `DisplayAs` as a component Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ `BentoImageSliderApi` namespace renamed to `Api` for precise meaning Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 🖍 Added `css` for `1.0`, 🐛 Minor bug fixes and `prettify` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Minor fix for `percent` validation check * ♻️ Removed superfluous trailing argument for `parseFloat` * 🧪 Experimental Code: Image Reference Issue This commit is intended to check and resolve image reference issue mentioned in discussion: #35783 (comment) Use keyboard "left" & "right" arrow key to move bar and slide images. Also, focus on the container to enable keyboard input to the component. * Fix ref issue in DisplayAsWithRef component (#5) * tickevents: remove unused enum values (#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * 📦 Update cimg/openjdk Docker tag to v17 (#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.57.0 (#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/graphql to v4.7.0 (#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️ Migrate `observeWithSharedInOb` to `observeIntersections` (#36106) * 🏗 Make setup-node step consistent across gh actions (#36175) * Partially revert "🏗 Parallelize `dist` steps (#35943)" (#36176) * Revert "🏗 Parallelize `dist` steps (#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve #35920 (#36103) removed a unlayout call that would cause the image to default to the first slide * ♻️ preact inob: small cleanup (#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (#36113) * Update Yandex & ADFOX amp-ad codes (#35442) * 🧪Update OT token for attribution-reporting (#36181) * 🏗 Add `exports` for stylesheets to `package.json` (#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * ✨ [bento][amp-iframe] Add validator rules for 1.0 (#36182) * 🚮 Sweep experiments older than 2021-02-01 (#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR #36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * 📦 Update dependency @octokit/rest to v18.11.2 (#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (#36191) * 📦 Update dependency @jest/core to v27.2.3 (#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.25 (#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (#36119) * 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency axios to 0.21.2 [SECURITY] (#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.13.3 (#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency tar to v6.1.9 [SECURITY] (#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * 🏗 Add nice colors to release tagger logs (#36200) * log * comment * 📦 Update core devDependencies (#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/worker-dom to v0.32.0 (#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency google-closure-library to v20210808 (#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (#36202) * 📦 Update dependency chromedriver to v94 (#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * 📦 Update dependency tar to v6.1.11 (#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📖 `bento-facebook` Documentation (#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * 🚮 Clean up dead amp-sidebar code within stories (#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * 🐛 [amp-story-panning-media] Set width on amp-img el (#36217) * Set width on amp-img el. * Add height * 📦 Update dependency @octokit/rest to v18.11.3 (#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.26.1 (#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/bento-compiler to v0.0.9 (#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️Don't fetch crypto signature verifier in no-signing (#36187) * 🐛 Force transfer of `amp-consent` element to the `FixedLayer` (#36223) Fixes #36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * 📦 Update core dependencies (#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.58.0 (#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/rest to v18.11.4 (#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (#36210) * [bento][amp-iframe] changes to publish to npm (#36190) * 🐛 fix broken link to Preact/React component section in various README (#36222) * 🏗 release: Update self-hosting support to use amp release (#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (#36131) * bento amp-iframe: guard effect from running without a win (#36241) * 🚀 babel/terser: rename all amp privates with sentinel suffix (#36143) * configs: Separate user configs from output files (#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com> * Fix bento slider issues (#12) * Refactor bento amp image slider markup * Fix label styling * Fix hints and slider touch gestures * Add storybook styling for custom label and hints * Remove unneccesary code * Add comments for `containerClass` and `initLogContructor` * Update import path using alias * ♻️ Update alias, update AMP example * 🏗 Update compilation config * 🖍 Fix for `amp-img` size * ♻️ Update image `selector` order * ♻️ Minor fix passing class name * Fix bento image slider misc issues (#14) * Add slot for custom hints and fix label markup * Implement display-hint-once option and cleanup code * Fix LGTM check * Fix LGTM check * Use ContainWrapper for component wrapper * Fix circleCI checks * Add unit test cases for amp-image-slider component * Update initial position attribute in storybook * Add unit test code coverage * Fix flaky test cases * Fix unit test cases * Remove image slider 1.0 example file * Remove unused code * Remove unused code * Fix unlisten event function logic * ♻️ Minor fix, `lint` and `prettify` * ♻️ Update derived class extends using `setSuperClass` * ♻️ Correct dead links in `markdown` * ♻️ Remove `@storybook/addon-knobs` dependency from storybook * ♻️ Allow `src/service/timer-impl.js` dependency * ♻️ Update `Z_INDEX.md` * ♻️ Add check for `initialPosition` and `stepSize` * 🐛 Update `isFiniteNumber` with `isNaN` Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Edi Amin <to.ediamin@gmail.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Deepak Lalwani <deepak.lalwani81@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization, shaving ~1.5 minutes of wall time for developers and ~1 minute of VM time with no noticeable side effects. I reran the CircleCI workflow on this PR and on the
maincommit it's based on 3 times each, raw data:(I can rerun this more times if you want to see more data)