Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Remove idleRenderOutsideViewport #28043

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

dreamofabear
Copy link

Fixes #28012.

Removes source and tests originally added in #11952.

@amp-owners-bot amp-owners-bot bot requested a review from powerivq April 27, 2020 05:19
@dreamofabear dreamofabear changed the title 🚮Remove idleRenderOutsideViewport 🚮 Remove idleRenderOutsideViewport Apr 27, 2020
@dreamofabear dreamofabear requested a review from samouri April 27, 2020 15:15
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dreamofabear dreamofabear merged commit ab03e7c into ampproject:master Apr 27, 2020
@dreamofabear dreamofabear deleted the remove-idle-render branch April 27, 2020 19:59
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this pull request May 8, 2020
* First pass removing idleRenderOutsideViewport.

* Remove test code.
dreamofabear pushed a commit that referenced this pull request May 11, 2020
dreamofabear pushed a commit that referenced this pull request May 11, 2020
gmajoulet pushed a commit that referenced this pull request May 11, 2020
gmajoulet pushed a commit that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove idleRenderOutsideViewport()
5 participants