Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove idleRenderOutsideViewport() #28012

Closed
dreamofabear opened this issue Apr 24, 2020 · 4 comments · Fixed by #28043
Closed

Remove idleRenderOutsideViewport() #28012

dreamofabear opened this issue Apr 24, 2020 · 4 comments · Fixed by #28043
Assignees
@dreamofabear
Labels
P2: Soon Type: Bug WG: runtime

Comments

@dreamofabear
Copy link

Only used by amp-ad-network-doubleclick-impl and confirmed OK to remove by ads team.
@dreamofabear dreamofabear self-assigned this Apr 24, 2020
@dreamofabear
Copy link
Author

Self-assigning for weekend #mariekondo.

@dreamofabear dreamofabear mentioned this issue Apr 27, 2020
Merged
@calebcordry calebcordry reopened this May 11, 2020
@calebcordry
Copy link
Member

Took me a bit to realize what happened here. IIUC with the even with exp turned off any ad unit not using data-loading-strategy will have this value set to 12, explaining why elimination of this feature would have such measurable impact.

amphtml/extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

Line 356 in 5365f61

return vpRange || 12;

@dreamofabear
Copy link
Author

Yea, also confusing since idleRenderOutsideViewport is supposed to return a boolean.

@dreamofabear
Copy link
Author

Closing as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
P2: Soon Type: Bug WG: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚮 Remove idleRenderOutsideViewport dreamofabear/amphtml
2 participants
@calebcordry @dreamofabear