update babel-plugin-transform-amp-asserts with devAssert removal.

[erwinmombay]

Currently the transformer does not remove devAssert (we should leave userAssert's alone).

[erwinmombay]

@jridgewell @rsimha PTAL

[rsimha]

LGTM. Will defer to @jridgewell to review and approve.

[rsimha]

From the single pass failure logs, I see two issues:

• Closure is complaining while DCEing the remnants of the assert removals
• It appears that paths are being needlessly duplicated. For example, ads/google/a4a/ads/google/a4a/utils.js

[erwinmombay]

@rsimha could you explain what you mean by "It appears that paths are being needlessly duplicated. For example, ads/google/a4a/ads/google/a4a/utils.js" ?

[rsimha]

@rsimha could you explain what you mean by "It appears that paths are being needlessly duplicated. For example, ads/google/a4a/ads/google/a4a/utils.js" ?

The path should be ads/google/a4a/utils.js (the ads/google/a4a prefix is duplicated). I'm seeing the same pattern in most of the warnings printed by closure. Perhaps there's a missing base: <PATH> option to a gulp.src() somewhere?

[mrjoro]

Is this PR still active?

[rsimha]

@jridgewell @erwinmombay Today, AmpPass.java eliminates all these calls:

amphtml/build-system/runner/src/org/ampproject/AmpCommandLineRunner.java

Lines 43 to 56 in d7f3349

	/**
	* List of string suffixes to eliminate from the AST.
	*/
	ImmutableSet<String> suffixTypes = ImmutableSet.of(
	"dev$$module$src$log().assert()",
	"dev$$module$src$log().fine()",
	"dev$$module$src$log().assertElement()",
	"dev$$module$src$log().assertString()",
	"dev$$module$src$log().assertNumber()",
	"dev$$module$src$log().assertArray()",
	"dev$$module$src$log().assertBoolean()",
	"devAssert$$module$src$log()",
	"user$$module$src$log().fine()"
	);

Does this PR remove all of them? If not, are there plans to do so?

[jridgewell]

They're all eliminated.

[rsimha]

They're all eliminated.

When I tried removing AmpPass.java, the number of instances of assert in v0.js jumped from 20 to ~80. I don't think assertElement, etc. are being removed.

[jridgewell]

Open an issue, please.

[rsimha]

Open an issue, please.

#23960