fix tests

ampproject · Jul 17, 2019 · e4910be · e4910be
1 parent 782b858
commit e4910be
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 17 deletions.
diff --git a/build-system/babel-plugins/babel-plugin-transform-amp-asserts/index.js b/build-system/babel-plugins/babel-plugin-transform-amp-asserts/index.js
@@ -53,8 +53,7 @@ module.exports = function(babel) {
         const {parenthesized} = node.extra || {};
 
         const isDirectCallExpression =
-          t.isIdentifier(callee, {name: 'devAssert'}) ||
-          t.isIdentifier(callee, {name: 'userAssert'});
+          t.isIdentifier(callee, {name: 'devAssert'});
         const isMemberAndCallExpression =
           t.isMemberExpression(callee) && t.isCallExpression(callee.object);
 
@@ -92,16 +91,6 @@ module.exports = function(babel) {
           type = typeMap[property.name];
         }
 
-        // If the CallExpression's direct parent is a ExpressionStatement
-        // we can remove the whole call. Closure Compiler doesn't seem to
-        // DCE the arguments that we leave behind even though they might be
-        // raw strings without any side effects.
-        const isParentDirectExpStatement = t.isExpressionStatement(path.parent);
-        if (isParentDirectExpStatement) {
-          path.remove();
-          return;
-        }
-
         if (args) {
           if (parenthesized) {
             path.replaceWith(t.parenthesizedExpression(args));

diff --git a/...-assertions/transform-userAssert/input.js → ...sertions/no-transform-userAssert/input.js b/...-assertions/transform-userAssert/input.js → ...sertions/no-transform-userAssert/input.js
diff --git a/...ertions/transform-userAssert/options.json → ...ions/no-transform-userAssert/options.json b/...ertions/transform-userAssert/options.json → ...ions/no-transform-userAssert/options.json
diff --git a/...assertions/transform-userAssert/output.js → ...ertions/no-transform-userAssert/output.js b/...assertions/transform-userAssert/output.js → ...ertions/no-transform-userAssert/output.js
@@ -13,8 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-1 + 1;
-2 + 2;
-undefined;
-let result = dev();
-let result2 = undefined;
+userAssert(1 + 1);
+userAssert(2 + 2);
+userAssert();
+let result = userAssert(dev(), 'hello', 'world');
+let result2 = userAssert();