Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to implement: Player embed by nexxPLAY #7673

Closed
neko-fire opened this issue Feb 20, 2017 · 9 comments
Closed

Intent to implement: Player embed by nexxPLAY #7673

neko-fire opened this issue Feb 20, 2017 · 9 comments
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code

Comments

@neko-fire
Copy link
Contributor

neko-fire commented Feb 20, 2017

The goal is to implement a simple media player element to allow embedding of media formats such as video and audio from nexxPLAY.

it would look like this:

    <amp-nexxtv-player
        data-videoid="872E97169LE9JLU"
        data-client="484"
        data-streamtype="video"
        data-autoplay="0"
        data-delay="20"
        data-mode="static"
    ></amp-nexxtv-player>

You can read more detailed information about nexxPLAY on our website http://www.nexx.tv/

fork
https://github.com/nexxtv/amphtml/tree/nexxtv-player

branch: nexxtv-player

@aghassemi
Copy link
Contributor

@neko-fire Great! Looking forward to seeing the PR for this.

Couple of questions and notes:
1- What other values are supported by data-streamtype and data-mode?
2- Do you have a postMesssage API for the player than can be used to implement the video-interface?

The video-interface is a common API that AMP expects all video players to implement (not all do at the moment however). This allows AMP to treat all video players the same and to use it to provide common UX across players such as autoplay, dockable videos, managing playback across players, etc... The interface is fairly straighforward: common methods and events such as play, pause, muted, etc..

Therefore I recommend:
1- amp-nexxtv-player to implement the video-interface. Please look at amp-youtube.js for a reference implementation which uses postMessage to do the communication between the AMP component and the iframed video player to implement the interface. amp-ooyala-player is another player that also implements the interface.
2- Do not expose data-autoplay, AMP will manage autoplay for you (exposed as just autoplay attribute) if you implement the video-interface. This will ensure consistent autoplay UX across video players. (Here is demo of how AMP handles autoplay)
3- Is data-delay attribute for autoplay? If so, AMP-managed autoplay does not have that feature. Please find a GitHub feature request so we can add that for all video players that support autoplay.

@aghassemi aghassemi added Category: Audio&Video INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code labels Feb 21, 2017
@aghassemi aghassemi added this to the Pending 3P Implementation milestone Feb 21, 2017
@aghassemi
Copy link
Contributor

/cc @rudygalfi @ericlindley-g

@neko-fire
Copy link
Contributor Author

Hi @aghassemi,

Thank you for your feedback! Here are the answers to your questions:

  1. These streamtypes are possible fordata-streamtype
    -> video, audio, playlists, playlist-masked (playlist without possibility to skip or choose video), live, album (audio playlist)
  2. The parameter data-mode can have mode static or api. Static mode has lesser player functions, is faster and works without using our API.
  3. The autoplay attribute is removed
  4. data-delay is the starting point of a media (e.g. start video on 1:30min). I'll rename it.

I've seen the Video Interface, but currently we do not support postMessage API in our player.
I'll list all information in the readme of the extension.

@aghassemi
Copy link
Contributor

Thanks for the responses @neko-fire.

  1. Sounds good.
  2. Considering page authors can not write custom JavaScript in AMP, is there any reason to ever use data-mode=api? If not, I suggest not exposing this attribute and making static an unchangable default.
  3. Sounds good.
  4. How about data-seek-to=<second> ?
  5. Regarding video-interface. We like to push for amp-nexxtv-player to implement this interface. Would you please consider also pushing for this internally? My apologies for pushing for this, but I believe at the end of the day all parties will benefit from it. Users will have a better video experience as they increasingly expect autoplaying videos with good and uniform UX on mobile and features like picture-in-picture that AMP will provide for free using the API. Publisher will benefit from the extra features amp-nexxtv-player will provide them to satisfy their users and hopefully nexxtv will see increased adoption/watch-time based on important differentiators like mobile autoplay of videos and picture-in-picture support.

@neko-fire
Copy link
Contributor Author

neko-fire commented Feb 23, 2017

Hi @aghassemi

Thanks for your feedback!

  1. Unfortunately we can't. Clients can choose between modes, which refer to different monetizing models for us and our client. It's very important for us.
  2. From our side, postMessage API for our player is still in development. We just decided to implement it alongside with AMP.

There is an additional attribute called data-origin. The embed url for media can vary by client. I hope thats alright.

@aghassemi
Copy link
Contributor

@neko-fire Sounds good. Thanks so much for your commitment to do the postMessage API! Please proceed with a PR, looking forward to it.

@neko-fire
Copy link
Contributor Author

Hi @aghassemi ,

is there a way to test sending postMessages from AMP -> Player? I could'nt find any ressource or guide line of how to test it properly.
You can also have a look at the first draft here https://github.com/nexxtv/amphtml/blob/nexxtv-player/extensions/amp-nexxtv-player/0.1/amp-nexxtv-player.js

@aghassemi
Copy link
Contributor

@neko-fire We have an integration test suite for the players that implement the video-interface. Just adding your player to that suite will test your code end-to-end, making sure postMessages go through and events propagate back, etc..

I recommend manually testing your implementation first with the autoplay attribute and fixing the bugs then you can easily add it to the integration test suite by adding a few lines to video-players.html and test-video-players.js

for the draft https://github.com/nexxtv/amphtml/blob/nexxtv-player/extensions/amp-nexxtv-player/0.1/amp-nexxtv-player.js implementation of the methods looks good, but not the events. You need to
1- Trigger VideoEvents.LOAD when the playerReadyPromise_ resolves.
2- Have the iframe send postMessages back to the component when events such as pause, play, mute, unmute happen in the player and dispatch them on the component (e.g. If user taps the Play action in your player, your component needs to dispatch the VideoEvents.PLAY event )

@neko-fire
Copy link
Contributor Author

@aghassemi Thanks a lot!

erwinmombay pushed a commit that referenced this issue Mar 9, 2017
* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* fixed linting issues (#7673)

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* fixed linting issues (#7673)

* nexxtv player review fixes (#7816)

* nexxtv player: updated validation rules (#7816)

* nexxtv player validator ordered alphabetical, changed spec_url

* fire amp-dom-update event on insert and replace (#7819)

* temp

* trigger `amp-dom-update` event on insert and replace

* switch -amp-form to i-amp-form

* Validator Rollup (#7844)

* Revision bump.

* Revision bump for amp-playbuzz changes in #7450

* Revision bump.

* Allow filtering by HtmlFormat (AMP, AMP4ADS) in the code generator.

* Revision bump.

* Revision bump due to Github pull.

* Code generation now driven by a variable LIGHT, which is broader than the previous GENERATE_DETAILED_ERRORS distinction. LIGHT implies filtered for specific format (AMP or AMP4ADS, and only amp.validator.validateSaxEvents, and no detailed errors.

* Generate ValidatorRules.directAttrLists and globalAttrs and ampLayoutAttrs, reducing overhead by indirection.

* Implement parallax effect extension (#7794)

* Do not set hidden attribute on hide/collapse (#7879)

* amp-bind: Support `Math` functions (#7797)

* initial commit for Math in amp-bind

* fix lint

* ali's comment

* avoid scope conflicts with built-in functions

* remove Math functions from documentation

* Measure 3P ad latency (#7902)

* Update spec URLs from github to ampproject. (#7901)

* Update github urls to ampproject urls

* test .out updated

* Too many slashes.

* Moved Developing.md and Design_Principles.md (#7908)

* Rename DEVELOPING.md to contributing/DEVELOPING.md

* Move files to new folder

* Renaming toggle to toggleVisibility because it was conflicting with sidebar and breaking it (#7855)

* disable scrollRestoration auto for embed case (#7899)

* Disable Fast Fetch for all ads when remote.html is used. (#7906)

* Fix DoubleClick Fast Fetch bugs around categoryExclusions and tagForChildDirectedTreatment (#7843)

* Fix incorrect parameter name for `tagForChildDirectedTreatment` in DoubleClick.

* Added unit test for tagForChildDirectedTreatment.

* Fixed the categoryExclusions bug in Fast Fetch DoubleClick.

* Removed parens in arrow functions to satisfy linter

* Adds two new experiment IDs (#7850)

* Adds two new experiment IDs to distinguish "any externally triggered" experiment from "any internally triggered".

Also updates tests to remove a number of assumptions that only a single eid will be populated.

* Use return val to detect "externally selected"; test updates.

* Updated network implementation guide. (#7862)

* Updated network impl guide.

* Changed 'validation' to 'verification'

* Cid timeout error should not be dev error (#7911)

* Fix amp-ad test (#7918)

* Update amp-install-serviceworker.md (#7932)

Fully escape javascript regex.

* Update amp-cache-modifications.md (#7933)

Add `data-no-service-worker-fallback-shell-url` as a URL to be rewritten as absolute.

* amp-fx-parallax Don't use global (#7942)

* Viewer integration: rewrite error message to indicate request name (#7923)

* rewrite error message

* update

* ticks

* Fix up links in DEVELOPING.md (#7944)

We moved DEVELOPING.md to the contributing folder but didn't update many of the relative links accordingly.

* Popin ad extension document updated. (#7674)

* Add popin ad extension.

* register popin.

* Add resizeable attribute.

* Remove resizable.

* Implemented the render-start and no-content APIs.

* Fixed lint.

* Remove quatation.

* Use tei@popin.cc

* Rebase old commit .

* Fixed document because tag was not closed.

* I replaced the removed double quotes.

* Add double quotes.

* Support for bind expressions in mustache templates (#7602)

* first pass at adding/removing subtrees

* tests passing

* Add ability to add and remove bindings in the subtree rooted at a specific node

* lint fixes

* merge conflict

* ci issues

* some cleanup

* pr comments

* pr comments, new method of removing bindings for node and its children

* fix some lint warnings

* test and lint fixes

* mutation observer

* update comments

* add observer

* naive implementation

* cleanup

* clean

* cleanup bind impl

* very simple example of bind in a template

* pr comments

* lint errors

* pr comments

* cleanup

* lint errors

* pr comments

* pr comments and lint warnings

* typo

* comments

* more lint warnings

* pr comment

* change README

* cleanup

* pr comments

* pr comments 2

* lint warnings

* don't use foreach on Nodelist

* casting

* more ci warnings

* even more ci warnings

* even more ci warnings

* even more ci issues

* even more ci comments

* even more ci issues

* pr comments

* more pr comments

* fix refactoring oversight

* pr comments

* pr comments

* merge

* pr comments

* ci issues

* pr comments

* assertElement

* pr comments

* typo

* updating sanitizer

* fixing up sanitizer test

* pr comments

* pr comments

* expanded on amp-mustache tests

* pr comments

* remove class from whitelist

* restore whole sandbox

* update mustache validator test and output

* pr comments

* nexxtv player gulp check-types fixes (#7816)

* nexxtv player fix error gulp presumbit with postmessage (#7816)

* added dependency check for nexxtv player (#7816)

* nexxtv player minor fix in validator (#7816)

* nexxtv player fixed validator (#7816)

* fixed validator (#7816)
kmh287 pushed a commit to kmh287/amphtml that referenced this issue Mar 13, 2017
* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* fixed linting issues (ampproject#7673)

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* fixed linting issues (ampproject#7673)

* nexxtv player review fixes (ampproject#7816)

* nexxtv player: updated validation rules (ampproject#7816)

* nexxtv player validator ordered alphabetical, changed spec_url

* fire amp-dom-update event on insert and replace (ampproject#7819)

* temp

* trigger `amp-dom-update` event on insert and replace

* switch -amp-form to i-amp-form

* Validator Rollup (ampproject#7844)

* Revision bump.

* Revision bump for amp-playbuzz changes in ampproject#7450

* Revision bump.

* Allow filtering by HtmlFormat (AMP, AMP4ADS) in the code generator.

* Revision bump.

* Revision bump due to Github pull.

* Code generation now driven by a variable LIGHT, which is broader than the previous GENERATE_DETAILED_ERRORS distinction. LIGHT implies filtered for specific format (AMP or AMP4ADS, and only amp.validator.validateSaxEvents, and no detailed errors.

* Generate ValidatorRules.directAttrLists and globalAttrs and ampLayoutAttrs, reducing overhead by indirection.

* Implement parallax effect extension (ampproject#7794)

* Do not set hidden attribute on hide/collapse (ampproject#7879)

* amp-bind: Support `Math` functions (ampproject#7797)

* initial commit for Math in amp-bind

* fix lint

* ali's comment

* avoid scope conflicts with built-in functions

* remove Math functions from documentation

* Measure 3P ad latency (ampproject#7902)

* Update spec URLs from github to ampproject. (ampproject#7901)

* Update github urls to ampproject urls

* test .out updated

* Too many slashes.

* Moved Developing.md and Design_Principles.md (ampproject#7908)

* Rename DEVELOPING.md to contributing/DEVELOPING.md

* Move files to new folder

* Renaming toggle to toggleVisibility because it was conflicting with sidebar and breaking it (ampproject#7855)

* disable scrollRestoration auto for embed case (ampproject#7899)

* Disable Fast Fetch for all ads when remote.html is used. (ampproject#7906)

* Fix DoubleClick Fast Fetch bugs around categoryExclusions and tagForChildDirectedTreatment (ampproject#7843)

* Fix incorrect parameter name for `tagForChildDirectedTreatment` in DoubleClick.

* Added unit test for tagForChildDirectedTreatment.

* Fixed the categoryExclusions bug in Fast Fetch DoubleClick.

* Removed parens in arrow functions to satisfy linter

* Adds two new experiment IDs (ampproject#7850)

* Adds two new experiment IDs to distinguish "any externally triggered" experiment from "any internally triggered".

Also updates tests to remove a number of assumptions that only a single eid will be populated.

* Use return val to detect "externally selected"; test updates.

* Updated network implementation guide. (ampproject#7862)

* Updated network impl guide.

* Changed 'validation' to 'verification'

* Cid timeout error should not be dev error (ampproject#7911)

* Fix amp-ad test (ampproject#7918)

* Update amp-install-serviceworker.md (ampproject#7932)

Fully escape javascript regex.

* Update amp-cache-modifications.md (ampproject#7933)

Add `data-no-service-worker-fallback-shell-url` as a URL to be rewritten as absolute.

* amp-fx-parallax Don't use global (ampproject#7942)

* Viewer integration: rewrite error message to indicate request name (ampproject#7923)

* rewrite error message

* update

* ticks

* Fix up links in DEVELOPING.md (ampproject#7944)

We moved DEVELOPING.md to the contributing folder but didn't update many of the relative links accordingly.

* Popin ad extension document updated. (ampproject#7674)

* Add popin ad extension.

* register popin.

* Add resizeable attribute.

* Remove resizable.

* Implemented the render-start and no-content APIs.

* Fixed lint.

* Remove quatation.

* Use tei@popin.cc

* Rebase old commit .

* Fixed document because tag was not closed.

* I replaced the removed double quotes.

* Add double quotes.

* Support for bind expressions in mustache templates (ampproject#7602)

* first pass at adding/removing subtrees

* tests passing

* Add ability to add and remove bindings in the subtree rooted at a specific node

* lint fixes

* merge conflict

* ci issues

* some cleanup

* pr comments

* pr comments, new method of removing bindings for node and its children

* fix some lint warnings

* test and lint fixes

* mutation observer

* update comments

* add observer

* naive implementation

* cleanup

* clean

* cleanup bind impl

* very simple example of bind in a template

* pr comments

* lint errors

* pr comments

* cleanup

* lint errors

* pr comments

* pr comments and lint warnings

* typo

* comments

* more lint warnings

* pr comment

* change README

* cleanup

* pr comments

* pr comments 2

* lint warnings

* don't use foreach on Nodelist

* casting

* more ci warnings

* even more ci warnings

* even more ci warnings

* even more ci issues

* even more ci comments

* even more ci issues

* pr comments

* more pr comments

* fix refactoring oversight

* pr comments

* pr comments

* merge

* pr comments

* ci issues

* pr comments

* assertElement

* pr comments

* typo

* updating sanitizer

* fixing up sanitizer test

* pr comments

* pr comments

* expanded on amp-mustache tests

* pr comments

* remove class from whitelist

* restore whole sandbox

* update mustache validator test and output

* pr comments

* nexxtv player gulp check-types fixes (ampproject#7816)

* nexxtv player fix error gulp presumbit with postmessage (ampproject#7816)

* added dependency check for nexxtv player (ampproject#7816)

* nexxtv player minor fix in validator (ampproject#7816)

* nexxtv player fixed validator (ampproject#7816)

* fixed validator (ampproject#7816)
mrjoro pushed a commit to mrjoro/amphtml that referenced this issue Apr 28, 2017
* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* fixed linting issues (ampproject#7673)

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* nexxtv player changed indents from 4 spaces to 2

* added unlayoutCallback for nexxtv player

* initial setup for extension nexxtv-player

* added nexxtv player logic

* nexxtv player bugfixes, cleanup, tests, docs

* added video interface, changed attribute start to seek-to

* reworked video interface for nexxtv-player

* added message handler for nexxtv player and tests

* nexxtv player minor fixes & cleanup

* fixed linting issues (ampproject#7673)

* nexxtv player review fixes (ampproject#7816)

* nexxtv player: updated validation rules (ampproject#7816)

* nexxtv player validator ordered alphabetical, changed spec_url

* fire amp-dom-update event on insert and replace (ampproject#7819)

* temp

* trigger `amp-dom-update` event on insert and replace

* switch -amp-form to i-amp-form

* Validator Rollup (ampproject#7844)

* Revision bump.

* Revision bump for amp-playbuzz changes in ampproject#7450

* Revision bump.

* Allow filtering by HtmlFormat (AMP, AMP4ADS) in the code generator.

* Revision bump.

* Revision bump due to Github pull.

* Code generation now driven by a variable LIGHT, which is broader than the previous GENERATE_DETAILED_ERRORS distinction. LIGHT implies filtered for specific format (AMP or AMP4ADS, and only amp.validator.validateSaxEvents, and no detailed errors.

* Generate ValidatorRules.directAttrLists and globalAttrs and ampLayoutAttrs, reducing overhead by indirection.

* Implement parallax effect extension (ampproject#7794)

* Do not set hidden attribute on hide/collapse (ampproject#7879)

* amp-bind: Support `Math` functions (ampproject#7797)

* initial commit for Math in amp-bind

* fix lint

* ali's comment

* avoid scope conflicts with built-in functions

* remove Math functions from documentation

* Measure 3P ad latency (ampproject#7902)

* Update spec URLs from github to ampproject. (ampproject#7901)

* Update github urls to ampproject urls

* test .out updated

* Too many slashes.

* Moved Developing.md and Design_Principles.md (ampproject#7908)

* Rename DEVELOPING.md to contributing/DEVELOPING.md

* Move files to new folder

* Renaming toggle to toggleVisibility because it was conflicting with sidebar and breaking it (ampproject#7855)

* disable scrollRestoration auto for embed case (ampproject#7899)

* Disable Fast Fetch for all ads when remote.html is used. (ampproject#7906)

* Fix DoubleClick Fast Fetch bugs around categoryExclusions and tagForChildDirectedTreatment (ampproject#7843)

* Fix incorrect parameter name for `tagForChildDirectedTreatment` in DoubleClick.

* Added unit test for tagForChildDirectedTreatment.

* Fixed the categoryExclusions bug in Fast Fetch DoubleClick.

* Removed parens in arrow functions to satisfy linter

* Adds two new experiment IDs (ampproject#7850)

* Adds two new experiment IDs to distinguish "any externally triggered" experiment from "any internally triggered".

Also updates tests to remove a number of assumptions that only a single eid will be populated.

* Use return val to detect "externally selected"; test updates.

* Updated network implementation guide. (ampproject#7862)

* Updated network impl guide.

* Changed 'validation' to 'verification'

* Cid timeout error should not be dev error (ampproject#7911)

* Fix amp-ad test (ampproject#7918)

* Update amp-install-serviceworker.md (ampproject#7932)

Fully escape javascript regex.

* Update amp-cache-modifications.md (ampproject#7933)

Add `data-no-service-worker-fallback-shell-url` as a URL to be rewritten as absolute.

* amp-fx-parallax Don't use global (ampproject#7942)

* Viewer integration: rewrite error message to indicate request name (ampproject#7923)

* rewrite error message

* update

* ticks

* Fix up links in DEVELOPING.md (ampproject#7944)

We moved DEVELOPING.md to the contributing folder but didn't update many of the relative links accordingly.

* Popin ad extension document updated. (ampproject#7674)

* Add popin ad extension.

* register popin.

* Add resizeable attribute.

* Remove resizable.

* Implemented the render-start and no-content APIs.

* Fixed lint.

* Remove quatation.

* Use tei@popin.cc

* Rebase old commit .

* Fixed document because tag was not closed.

* I replaced the removed double quotes.

* Add double quotes.

* Support for bind expressions in mustache templates (ampproject#7602)

* first pass at adding/removing subtrees

* tests passing

* Add ability to add and remove bindings in the subtree rooted at a specific node

* lint fixes

* merge conflict

* ci issues

* some cleanup

* pr comments

* pr comments, new method of removing bindings for node and its children

* fix some lint warnings

* test and lint fixes

* mutation observer

* update comments

* add observer

* naive implementation

* cleanup

* clean

* cleanup bind impl

* very simple example of bind in a template

* pr comments

* lint errors

* pr comments

* cleanup

* lint errors

* pr comments

* pr comments and lint warnings

* typo

* comments

* more lint warnings

* pr comment

* change README

* cleanup

* pr comments

* pr comments 2

* lint warnings

* don't use foreach on Nodelist

* casting

* more ci warnings

* even more ci warnings

* even more ci warnings

* even more ci issues

* even more ci comments

* even more ci issues

* pr comments

* more pr comments

* fix refactoring oversight

* pr comments

* pr comments

* merge

* pr comments

* ci issues

* pr comments

* assertElement

* pr comments

* typo

* updating sanitizer

* fixing up sanitizer test

* pr comments

* pr comments

* expanded on amp-mustache tests

* pr comments

* remove class from whitelist

* restore whole sandbox

* update mustache validator test and output

* pr comments

* nexxtv player gulp check-types fixes (ampproject#7816)

* nexxtv player fix error gulp presumbit with postmessage (ampproject#7816)

* added dependency check for nexxtv player (ampproject#7816)

* nexxtv player minor fix in validator (ampproject#7816)

* nexxtv player fixed validator (ampproject#7816)

* fixed validator (ampproject#7816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code
Projects
None yet
Development

No branches or pull requests

3 participants