Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LightGBM model and the investigated TabNet architecture documentation #220

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Added LightGBM model and the investigated TabNet architecture documentation #220

merged 7 commits into from
Jan 29, 2024

Conversation

ultiwinter
Copy link
Contributor

@ultiwinter ultiwinter commented Jan 28, 2024 •
edited
Loading

Note: Includes changes done in PR #218 until 28.01.2024!

  • Added LightGBM to the pipeline, its performance is similar to XGBoost to some extent
  • Documented the results for LightGBM.
  • Investigated TabNet architecture, which didn't yield postive results, so I just added the documentation.

luccalb and others added 6 commits January 26, 2024 15:26
@luccalb
Add AdaBoost model and option to train on a subset of features
47a28f4 
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
@luccalb
Added experiment results and marked the best performing classifier pe…
d97d90f 
…r class

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
@luccalb
Minor changes to docs
076f688 
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
@ultiwinter7
Added LightGMB to the models
6248259 
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
@ultiwinter7
Added documented results about LightGBM
029009d 
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
@ultiwinter7
Added documentation about TabNet architecture
8f99e4f 
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
@ultiwinter ultiwinter linked an issue Jan 28, 2024 that may be closed by this pull request
Final iteration of ML model #216
Closed
@ultiwinter ultiwinter added the feature Specific feature, part of a certain module label Jan 28, 2024
@ultiwinter ultiwinter changed the title Adding LightGBM model and the investigated TabNet architecture documentation Added LightGBM model and the investigated TabNet architecture documentation Jan 28, 2024
luccalb
luccalb approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@luccalb luccalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ultiwinter
Merge branch 'dev' into feature/lightgbm-model
d0468c3 
Signed-off-by: Ahmed Sheta <95130956+ultiwinter@users.noreply.github.com>
@ultiwinter ultiwinter merged commit 1c79c6f into dev Jan 29, 2024
4 checks passed
@ultiwinter ultiwinter deleted the feature/lightgbm-model branch January 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luccalb luccalb luccalb approved these changes

@felix-zailskas felix-zailskas Awaiting requested review from felix-zailskas

@rbbozkurt rbbozkurt Awaiting requested review from rbbozkurt

Assignees
No one assigned
Labels
feature Specific feature, part of a certain module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Final iteration of ML model
3 participants
@ultiwinter @luccalb @ultiwinter7